Rollup of 6 pull requests #29900
Merged
Rollup of 6 pull requests #29900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Nov 17, 2015
steveklabnik
commented
- Successful merges: Remove claims of dependency-free libcore #29612, Mention libc from crates.io in TRPL: FFI #29888, Clear up the reference around let #29889, Clarify comment about structs and lifetimes #29890, Fix up escapes in the reference #29891, More docs for FromIterator #29892
- Failed merges:
Sometimes when writing generic code you want to abstract over
owning/pointer type so that calling code isn't restricted by one
concrete owning/pointer type. This commit makes possible such code:
```
fn i_will_work_with_arc<T: Into<Arc<MyTy>>>(t: T) {
let the_arc = t.into();
// Do something
}
i_will_work_with_arc(MyTy::new());
i_will_work_with_arc(Box::new(MyTy::new()));
let arc_that_i_already_have = Arc::new(MyTy::new());
i_will_work_with_arc(arc_that_i_already_have);
```
Please note that this patch doesn't work with DSTs.
under openbsd, the library path of libstdc++ need to be explicit (due to the fact the default linker `cc` is gcc-4.2, and not gcc-4.9). but when a recent LLVM is installed, rustc compilation pikes the bad LLVM version (which live in /usr/local/lib, which is same directory of libestdc++.so for gcc-4.9). this patch move the libstdc++ path from RUST_FLAGS_<target> to special variable, and use it *after* LLVM_LIBDIR_RUSTFLAGS_<target> in arguments.
The command-line error message for E0432 does mention the possibility of missing the `extern crate` declaration, but the detailed error message for it doesn't. Fixes rust-lang#29517.
[breaking change]
Fixes rust-lang#29853 Fixes rust-lang#29852 While these points are true, we're not going for 100% accuracy here, this is introductory material. Changing these things would be more confusing, but it is important to note that we're presenting an abstraction here.
…alexcrichton
Sometimes when writing generic code you want to abstract over
owning/pointer type so that calling code isn't restricted by one
concrete owning/pointer type. This commit makes possible such code:
```rust
fn i_will_work_with_arc<T: Into<Arc<MyTy>>>(t: T) {
let the_arc = t.into();
// Do something
}
i_will_work_with_arc(MyTy::new());
i_will_work_with_arc(Box::new(MyTy::new()));
let arc_that_i_already_have = Arc::new(MyTy::new());
i_will_work_with_arc(arc_that_i_already_have);
```
Please note that this patch doesn't work with DSTs.
Also to mention, I made those impls stable, and I don't know whether they should be actually stable from the beginning. Please tell me if this should be feature-gated.
They can be useful for constructing constant items.
I noticed the nomicon was not listed! I also removed links to racer and rustfmt since they were not *doc-specific* links, just links to tools, as well as pointed the cargo link directly at the docs. Removed all the community stuff. There are lots of other places to find this now, including the website. With pending website changes this page will continue to be pared back, reflecting only what's in-tree, not general Rust docs. r? @steveklabnik
…te, r=steveklabnik The command-line error message for E0432 does mention the possibility of missing the `extern crate` declaration, but the detailed error message for it doesn't. Fixes rust-lang#29517.
Duplicate entries removed. This doesn't quite completely allow for generating AUTHORS.txt from scratch but it's much closer now.
…chton With this change the build on FreeBSD is almost working again.
Change conditional perfect to past perfect.
- Successful merges: rust-lang#29868, rust-lang#29873, rust-lang#29874, rust-lang#29875, rust-lang#29876, rust-lang#29880, rust-lang#29881 - Failed merges:
[breaking change] I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](rust-lang#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
First, re-word the section on if let/while let to be more clear. Second, actually call them let statements in the statement section Fixes rust-lang#29801
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502 r? @alexcrichton
First, re-word the section on if let/while let to be more clear. Second, actually call them let statements in the statement section Fixes rust-lang#29801
…excrichton And modifying IntoIterator for consisntency with it. Part of rust-lang#29360
|
@bors: r+ p=1 |
|
📌 Commit 5c99fb7 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
the all-steve rollup today, i guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.