Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #28586 #29531

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Closes #28586 #29531

merged 1 commit into from
Nov 17, 2015

Conversation

bltavares
Copy link
Contributor

Cloases #28586

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Nov 3, 2015

Thanks @bltavares. Since this is a compile-fail test it needs to indicate what the expected error is. Can you modify the test to include an ^ERROR line? You can test it with make check-stage2-cfail TESTTNAME=issue-28586.

@bltavares
Copy link
Contributor Author

@brson sure thing. I just updated the branch and I'm running the tests locally.

@apasel422
Copy link
Contributor

@brson Is the error code sufficient here, or do we want at least some of the message itself?

@sanxiyn
Copy link
Member

sanxiyn commented Nov 17, 2015

Error code is sufficient.

@sanxiyn
Copy link
Member

sanxiyn commented Nov 17, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Nov 17, 2015

📌 Commit 58e2baa has been approved by sanxiyn

@bors
Copy link
Contributor

bors commented Nov 17, 2015

⌛ Testing commit 58e2baa with merge 8809a33...

bors added a commit that referenced this pull request Nov 17, 2015
@bors bors merged commit 58e2baa into rust-lang:master Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants