Remove claims of dependency-free libcore #29612
Conversation
|
libcore is "basically" dependency-free - it only depends on the equivalent of rlibc, rather than a system. |
|
Right, but "basically" isn't the same as "is". |
|
I'm a little sad to see this go, I fear that this level of pedantry takes away from the purpose of libcore and detracts from what it's doing. Perhaps something like a footnote could be added, although it probably just needs more explanation somewhere than just a small footnote. |
|
Should we not regard these dependencies as bugs? |
|
The main contention, from what I understand, is Other dependencies like |
|
How is |
|
If you produce a staticlib, dependencies like |
|
So, what's the call here? |
|
My preference would be to leave this and perhaps add a caveat indicating that some symbols are needed but they have canonical implementations and they aren't always all necessary. |
steveklabnik
force-pushed
the
gh29502
branch
from
faa8f72 to
60c84ee
Compare
|
@alexcrichton what do you think about this iteration? |
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502
| //! Rust Standard Library](../std/index.html). It is the portable glue | ||
| //! between the language and its libraries, defining the intrinsic and | ||
| //! primitive building blocks of all Rust code. It links to no | ||
| //! upstream libraries, no system libraries, and no libc. | ||
| //! | ||
| //! [^free]: Strictly speaking, there are some symbols which are needed but | ||
| //! they aren't always neccesary. |
There was a problem hiding this comment.
fun note: without the whitespace here, this won't render, but with it, it will
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502 r? @alexcrichton
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502 r? @alexcrichton
libcore does have a few deps, like noted in #29390
Fixes #29502
r? @alexcrichton