Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs claim libcore is dependency-free #29502

Closed
hanna-kruppe opened this issue Nov 1, 2015 · 0 comments
Closed

Docs claim libcore is dependency-free #29502

hanna-kruppe opened this issue Nov 1, 2015 · 0 comments

Comments

@hanna-kruppe
Copy link
Contributor

As noted in #29390 among other places, core is not really completely dependency-free. While this claim is defensible in some sense, the crate documentation could be more clear about what it means by this, for example by describing the criterion outlined by @alexcrichton in the aforementioned issue:

[...] having a few small "very well known" functions being unimplemented I think is fine (although they should obviously be minimized where possible).

The docs already talk about mem{cpy,cmp,set} and rust_begin_unwind, but in the meantime libcore gained a few other (intentionally) undefined symbols such as fmod and fmodf --- possibly others as well. The docs should explain those symbols too, and also explain how get around the need for them (don't use % on floats, link with --gc-sections).

@hanna-kruppe hanna-kruppe changed the title Docs claim libcore it is dependency-free Docs claim libcore is dependency-free Nov 1, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue Nov 17, 2015
libcore does have a few deps, like noted in rust-lang#29390

Fixes rust-lang#29502
steveklabnik added a commit to steveklabnik/rust that referenced this issue Nov 17, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants