fix: 0 rendered in discover when there are no results

[d-buckner]

Description

This is to resolve a bug where a 0 is rendered in discover when there are no results. This is due to the following logic
{tabs.length && (... which leads the 0 to be rendered as React will only skip rendering false, null, or undefined values in the render template.

Screenshot

Before

After

Changelog

• fix: 0 rendered in discover when there are no results

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (47a2351) to head (1e42ca6).
Report is 28 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/application/components/no_results/no_results.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9153      +/-   ##
==========================================
- Coverage   60.95%   60.94%   -0.02%     
==========================================
  Files        3809     3809              
  Lines       91270    91270              
  Branches    14414    14414              
==========================================
- Hits        55634    55620      -14     
- Misses      32082    32096      +14     
  Partials     3554     3554              

Flag	Coverage Δ
Linux_1	28.97% <0.00%> (ø)
Linux_2	56.45% <ø> (ø)
Linux_3	37.97% <0.00%> (ø)
Linux_4	29.03% <0.00%> (ø)
Windows_1	28.98% <0.00%> (-0.02%)	⬇️
Windows_2	56.40% <ø> (ø)
Windows_3	37.97% <0.00%> (+<0.01%)	⬆️
Windows_4	29.03% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9153-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2aac3ee0dec6ba9690da41b4a894fbf360ba7e8e
# Push it to GitHub
git push --set-upstream origin backport/backport-9153-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9153-to-2.x.