Follow up on #9048 by updating data and utilities #9060

ananzh · 2024-12-16T18:36:26Z

Description

Merge feature branch PRs:
Add workspace utility #9038 Add test data for query enhancement functional tests #9006
Add sample test a_check.spec.js
Update utilities and data

To Run

// Download opensearch artifact and unzip
wget https://artifacts.opensearch.org/releases/bundle/opensearch/2.17.0/opensearch-2.17.0-linux-x64.tar.gz
tar -xvf opensearch-2.17.0-linux-x64.tar.gz
// remove security
./bin/opensearch-plugin remove opensearch-security
./opensearch-tar-install.sh
// enable workspace in confid/opensearch_dashboards.yml
workspace.enabled: true
opensearch.ignoreVersionMismatch: true
// run osd
yarn start:enhancements --no-base-path

Issues Resolved

#9178

Changelog

skip

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Feature branch PRs: opensearch-project#9038 opensearch-project#9006 Signed-off-by: Anan <ananzh@amazon.com>

codecov · 2024-12-16T18:52:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.86%. Comparing base (442e11e) to head (474c2e5).
Report is 67 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9060   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files        3808     3808           
  Lines       91209    91209           
  Branches    14410    14410           
=======================================
  Hits        55516    55516           
+ Misses      32156    32153    -3     
- Partials     3537     3540    +3

Flag	Coverage Δ
Linux_1	`29.02% <ø> (ø)`
Linux_2	`56.38% <ø> (ø)`
Linux_3	`37.93% <ø> (ø)`
Linux_4	`29.01% <ø> (ø)`
Windows_1	`29.03% <ø> (ø)`
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.93% <ø> (+<0.01%)`	⬆️
Windows_4	`29.01% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LDrago27 · 2024-12-16T19:53:00Z

cypress/integration/apps/query_enhancements/constants.js

+
+export const BASE_PATH = Cypress.config().baseUrl;
+export const DATASOURCE_NAME = 'test_cluster';
+export const DATASOURCE_URL = 'http://localhost:9200';


We can update the DataSource_URL to use the openSearchUrl: 'http://localhost:9200' defined within this file

will clean out all the base path and url in another follow-up

LDrago27 · 2024-12-16T23:16:55Z

.github/workflows/cypress_workflow.yml

@@ -90,7 +90,7 @@ jobs:
      options: --user 1001
    env:
      START_CMD: ${{ matrix.config == 'query_enhanced' &&
-        'node scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true --csp.warnLegacyBrowsers=false --uiSettings.overrides["query:enhancements:enabled"]=true --uiSettings.overrides[''home:useNewHomePage'']=true --data_source.enabled=true --opensearch.ignoreVersionMismatch=true' ||
+        'node scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true --csp.warnLegacyBrowsers=false --uiSettings.overrides["query:enhancements:enabled"]=true --uiSettings.overrides[''home:useNewHomePage'']=true --data_source.enabled=true --workspace.enable=true --opensearch.ignoreVersionMismatch=true' ||


Typo --workspace.enable=true should be --workspace.enabled=true

nice. thanks a lot.

We need to have tests run with and without workspaces being enabled.

kavilla · 2024-12-18T01:38:19Z

...ion/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/queries.spec.js

why we moving to integration/core-opensearch-dashboards/opensearch-dashboards

this is too long and what other tests would exist in this repo besides the core opensearch dashboards tests?

kavilla · 2024-12-18T01:39:14Z

cypress/lib/test-fixture-handler.js

+ */
+
+export class TestFixtureHandler {
+  constructor(inputTestRunner, openSearchUrl = 'localhost:9200') {


we aren't we pulling from the cypyress environment variable ?

kavilla · 2024-12-18T01:40:49Z

cypress/lib/test-fixture-handler.js

+  }
+
+  _extractIndexNameFromPath(filepath) {
+    const filename = filepath.split('/').pop();


i dont think this is worth it and requires knowing the system. to the point where it might just be easier to require the index name as apart of the file fixture

we don't use this one. it is for easy migration.

kavilla · 2024-12-18T01:42:33Z

cypress/utils/dashboards/commands.js

+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+Cypress.Commands.add('selectFromDataSourceSelector', (dataSourceTitle, dataSourceId) => {


seeing this as a datasource command as well im not positive what goes into utils/commands and what goes into query_enhancements/commands which all have a data source command

we don't use this one. it is for easy migration.

kavilla · 2024-12-18T01:42:55Z

cypress/utils/dashboards/commands.js

+
+Cypress.Commands.add('selectFromDataSourceSelector', (dataSourceTitle, dataSourceId) => {
+  // clean up the input field
+  cy.wait(1000);


:( cy.wait make tests flaky

we don't use this one. it is for easy migration.

kavilla · 2024-12-18T01:45:44Z

cypress/utils/dashboards/remove_workspace.js

+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+export function removeSampleDataAndWorkspace(url, workspaceName) {


this seems like util functions but they are tests. if this helper functions fail does the entire test fail?

if so this seems wrong. we shouldn't use E2E testing if we are doing test setup. it's too slow and flaky. we should use the saved objects api which workspaces supports and just execute queries.

we don't use this one. it is for easy migration.

kavilla · 2024-12-18T01:48:12Z

package.json

@@ -86,7 +86,7 @@
    "release_note:generate": "scripts/use_node scripts/generate_release_note",
    "cypress:run-without-security": "env TZ=America/Los_Angeles NO_COLOR=1 cypress run --env SECURITY_ENABLED=false",
    "cypress:run-with-security": "env TZ=America/Los_Angeles NO_COLOR=1 cypress run --env SECURITY_ENABLED=true,openSearchUrl=https://localhost:9200,WAIT_FOR_LOADER_BUFFER_MS=500",
-    "osd:ciGroup10": "echo \"cypress/integration/apps/query_enhancements/queries.spec.js,cypress/integration/apps/query_enhancements/dataset_selector.spec.js\"",
+    "osd:ciGroup10": "echo \"cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/a_check.spec.js\"",


so we are not gunna execute the queries.spec and dataset_selector.spec?

explained below

kavilla · 2024-12-18T01:48:39Z

cypress/support/e2e.js

+
+import { TestFixtureHandler } from '../lib/test-fixture-handler';
+
+Cypress.Commands.add('setupTestData', (mappingFiles, dataFiles) => {


shouldn't this be in the utils/commands

kavilla · 2024-12-18T01:49:18Z

cypress/lib/test-fixture-handler.js

did the linter not catch this file name? i think we are suppose to use _

kavilla

blocking because this will no longer run the existing tests. it just runs the check spec file

ananzh · 2024-12-18T03:06:19Z

blocking because this will no longer run the existing tests. it just runs the check spec file

I think this is expected. The two tests are written when we haven't enable workspace. We will modify these two tests:

cypress/integration/apps/query_enhancements/dataset_selector.spec.js
cypress/integration/apps/query_enhancements/queries.spec.js

enable workspace 2) modify utilities to use endpoint 3) migrate test lib to main (TestFixtureHandler and MiscUtils)

Signed-off-by: Anan <ananzh@amazon.com>

tests will be re-added.

…pensearch-project#9060) * Follow up on opensearch-project#9048 by updating data and utilities Feature branch PRs: opensearch-project#9038 opensearch-project#9006 Signed-off-by: Anan <ananzh@amazon.com> * fix comment Signed-off-by: Anan <ananzh@amazon.com> * update path and add utility from suchit commit Signed-off-by: Anan <ananzh@amazon.com> * update the path to run sample test Signed-off-by: Anan <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan <ananzh@amazon.com> * skip tests before enable workspace Signed-off-by: Anan <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com>

…ing backports (#9261) * [Discover] Makes caching dataset options optional (#8799) * [Discover] Makes caching dataset options optional. * Adds unit test * Changeset file for PR #8799 created/updated * Update test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * Upgrade Cypress to v12 (#8995) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Add required e2e.js Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * Update license in e2e.js Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * fix lint Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover Test] TestID-69: Filtering. Add data-test-subj tags. (#9027) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Add required e2e.js Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * Update license in e2e.js Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * fix lint Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add data-test-subj tags. Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Migrate query enhancement tests from functional repo to main (#9048) * migrate query enhacenement tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * ignore lint in data files Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove yarn lock changes Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add missing data-test-subj tags for discover plugin (#9049) * Add data-test-subj for discover Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix comment Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Add missing data-test-subj tags for data plugin (#9051) * Add missing data-test-subj tags for data plugin * Update Snapshots * Fix as per the comments --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Follow up on #9048 by updating data and utilities (#9060) * Follow up on #9048 by updating data and utilities Feature branch PRs: #9038 #9006 Signed-off-by: Anan <ananzh@amazon.com> * fix comment Signed-off-by: Anan <ananzh@amazon.com> * update path and add utility from suchit commit Signed-off-by: Anan <ananzh@amazon.com> * update the path to run sample test Signed-off-by: Anan <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan <ananzh@amazon.com> * skip tests before enable workspace Signed-off-by: Anan <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> * refactor some query-enhancement utility functions, add some missing typings (#9074) * refactor some query-enhancement utility functions, add some missing typings Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9074 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add queryEditorLanguageOptions data-test-subj on language_selector.tsx (#9029) Signed-off-by: Federico Silva <federico.silva.-nd@disney.com> Co-authored-by: Federico Silva <federico.silva.-nd@disney.com> * Re-enable dataset_selector.spec.js and queries.spec.js under workspace (#9082) * Re-enable dataset_selector.spec.js and queries.spec.js under workspace Signed-off-by: Anan <ananzh@amazon.com> * fix comment Signed-off-by: Anan <ananzh@amazon.com> * add verifyHitCount for PPL Signed-off-by: Anan <ananzh@amazon.com> * Changeset file for PR #9082 created/updated --------- Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Make createWorkspaceIndexPatterns to handle no default cluster and clean up (#9129) * Make createWorkspaceIndexPatterns to handle no default cluster and clean up Signed-off-by: Anan <ananzh@amazon.com> * Changeset file for PR #9129 created/updated --------- Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add data-test-subj (#9135) Signed-off-by: Federico Silva <federico.silva.dev@gmail.com> * [Discover] Adding Cypress Tests for S3 Datasets (#9113) * [Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) (#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add tests for saved search creation and loading for query enhancement (#9112) * Add tests for saved search creation and loading for query enhancement * click on a random element before typing on query editor to bypass the popover that appears * address pr comments - refactor to create saved search as an api call * address pr comments - specifically navigate to discover page before setting datasource Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * fix: 0 rendered in discover when there are no results (#9153) * fix: 0 rendered in discover when there are no results Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #9153 created/updated --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Cypress][Fix] Update saved search utilities (#9151) * update saved search * minor refactor4 on setDatePickerDatesAndSearchIfRelevant Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * chore: use relative paths in cypress (#9079) * chore: use relative paths in cypress when we move to running tests in parallel we won't be able to use a single hardcoded basepath as these can differ by tasks Signed-off-by: Daniel Rowe <rowdane@amazon.com> * Changeset file for PR #9079 created/updated --------- Signed-off-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) (#9166) * add spec for old ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <contactme@chunkeili.com> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <contactme@chunkeili.com> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix DataSource url Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <contactme@chunkeili.com> * Remove final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Fix final force. Signed-off-by: Argus Li <contactme@chunkeili.com> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <contactme@chunkeili.com> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <contactme@chunkeili.com> * fix import Signed-off-by: Argus Li <contactme@chunkeili.com> --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * change casing to folder structures to be compliant with our rules (#9197) Signed-off-by: Justin Kim <jungkm@amazon.com> * [Fix] Saved Search Integ Test Update: update saving a new saved search test spec (#9200) * wait for the page to be loaded before loading a saved search * when loading a saved search and saving it as a new saved search, use a different name Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> * refactor query enhancement tests (#9208) Signed-off-by: Justin Kim <jungkm@amazon.com> * chore: change casing of data-logs to be compliant with our git hook rules (#9220) Signed-off-by: Justin Kim <jungkm@amazon.com> * chore: remove unused/redundant functions from field_display_filtering utils (#9219) Signed-off-by: Justin Kim <jungkm@amazon.com> * Create cypress command namespacing util (#9150) * update cy.createInitialWorkspaceWithDataSource -> cy.osd.createInitialWorkspaceWithDataSource (#9262) Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Daniel Rowe <rowdane@amazon.com> Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Signed-off-by: Argus Li <contactme@chunkeili.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Federico Silva <federico.silva.-nd@disney.com> Signed-off-by: Federico Silva <federico.silva.dev@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com> Co-authored-by: Argus Li <43020525+ArgusLi@users.noreply.github.com> Co-authored-by: Daniel Rowe <rowdane@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com> Co-authored-by: Justin Kim <jungkm@amazon.com> Co-authored-by: Federico Silva <federico.silva@improving.com> Co-authored-by: Federico Silva <federico.silva.-nd@disney.com> Co-authored-by: Federico Silva <federico.silva.dev@gmail.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: d rowe <51932404+d-buckner@users.noreply.github.com>

Follow up on opensearch-project#9048 by updating data and utilities

1ce8fe6

Feature branch PRs: opensearch-project#9038 opensearch-project#9006 Signed-off-by: Anan <ananzh@amazon.com>

github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 16, 2024

LDrago27 reviewed Dec 16, 2024

View reviewed changes

LDrago27 force-pushed the follow-up-9048 branch from 1ce8fe6 to b7f4609 Compare December 16, 2024 20:19

LDrago27 reviewed Dec 16, 2024

View reviewed changes

kavilla reviewed Dec 18, 2024

View reviewed changes

kavilla previously requested changes Dec 18, 2024

View reviewed changes

LDrago27 previously approved these changes Dec 18, 2024

View reviewed changes

ananzh dismissed LDrago27’s stale review via 290c3cb December 18, 2024 03:34

ananzh force-pushed the follow-up-9048 branch from 290c3cb to 454b7e3 Compare December 18, 2024 03:46

fix PR comments

6fa6cb6

Signed-off-by: Anan <ananzh@amazon.com>

ananzh force-pushed the follow-up-9048 branch from 454b7e3 to 6fa6cb6 Compare December 18, 2024 03:51

ananzh mentioned this pull request Dec 18, 2024

[Discover 2.0 Testing] TestId-69: Filtering #9047

Closed

skip tests before enable workspace

474c2e5

Signed-off-by: Anan <ananzh@amazon.com>

ananzh force-pushed the follow-up-9048 branch from 0636882 to 474c2e5 Compare December 18, 2024 15:39

AMoo-Miki approved these changes Dec 18, 2024

View reviewed changes

LDrago27 approved these changes Dec 18, 2024

View reviewed changes

ananzh merged commit f9c463d into opensearch-project:main Dec 18, 2024
69 checks passed

ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Dec 18, 2024

ananzh mentioned this pull request Jan 13, 2025

[No Index Pattern] Load discover should show discoverNoIndexPatterns panel when no index pattern is created #9178

Closed

angle943 mentioned this pull request Jan 18, 2025

Backport/backport lots of prs for discover 2.0 #9218

Closed

7 tasks

ananzh mentioned this pull request Jan 23, 2025

[2.x Manual Backport] Backport cypress related work to 2.x and 2 missing backports #9261

Merged

7 tasks

ananzh added the v2.19.0 label Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up on #9048 by updating data and utilities #9060

Follow up on #9048 by updating data and utilities #9060

ananzh commented Dec 16, 2024 •

edited

Loading

codecov bot commented Dec 16, 2024 •

edited

Loading

LDrago27 Dec 16, 2024 •

edited

Loading

ananzh Dec 17, 2024

LDrago27 Dec 16, 2024

ananzh Dec 17, 2024

AMoo-Miki Dec 17, 2024 •

edited

Loading

kavilla Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla Dec 18, 2024

ananzh Dec 18, 2024

kavilla left a comment •

edited

Loading

ananzh commented Dec 18, 2024 •

edited

Loading


		import { TestFixtureHandler } from '../lib/test-fixture-handler';

		Cypress.Commands.add('setupTestData', (mappingFiles, dataFiles) => {

Follow up on #9048 by updating data and utilities #9060

Follow up on #9048 by updating data and utilities #9060

Conversation

ananzh commented Dec 16, 2024 • edited Loading

Description

To Run

Issues Resolved

Changelog

Check List

codecov bot commented Dec 16, 2024 • edited Loading

Codecov Report

LDrago27 Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AMoo-Miki Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kavilla left a comment • edited Loading

Choose a reason for hiding this comment

ananzh commented Dec 18, 2024 • edited Loading

ananzh commented Dec 16, 2024 •

edited

Loading

codecov bot commented Dec 16, 2024 •

edited

Loading

LDrago27 Dec 16, 2024 •

edited

Loading

AMoo-Miki Dec 17, 2024 •

edited

Loading

kavilla left a comment •

edited

Loading

ananzh commented Dec 18, 2024 •

edited

Loading