-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve terminal marker placements on windows #209136
fix: improve terminal marker placements on windows #209136
Conversation
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
f47baf3
to
83b639d
Compare
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Show resolved
Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Show resolved
Hide resolved
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh
Show resolved
Hide resolved
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
I fixed the stray markers, avoid adjusting the prompt start if the text is wrapped, and 1-2 small issues I found testing. Here are some new demo videos No Adjust When Wrappedfixed_bashNoAdjustOnWrap.mp4Multi-line Git Bash Adjustfixed_bashInputAdjust.mp4Multi-line Pwsh Adjustfixed_pwshMutliInputAdjust.mp4Single-line Pwsh Adjustfixed_pwshInputAdjust.mp4 |
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
7ebd75c
to
33064ec
Compare
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
I think I fixed it, there were small bugs. It's working for git bash (starship, default multiline, singleline) & pwsh (starship, oh-my-posh [json theme], & default)
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Oh I was testing an old version 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Revert "Merge pull request #209136 from cpendery/fix/improve-marker-p…
…placements fix: improve terminal marker placements on windows
Revert "Merge pull request microsoft#209136 from cpendery/fix/improve-marker-p…
This PR attempts to approve terminal marker placements on Windows in 2 ways.
note: while this will result in the starting line of a multiline prompt getting captured in the output, it improves the sticky scroll behavior significantly.
Sticky Scroll Pre Fix
stickyScrollBad.mp4
Sticky Scroll Post Fix
stickyScrollFix.mp4
Input Prompt Adjustment Example 1
markerInputCorrection2.mp4
Input Prompt Adjustment Example 2
markerInputCorrection.mp4
Related to #143769 & #209003