Make bash window prompt adjuster more strict #210776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
approved these changes
Apr 19, 2024
|
Yeah was thinking about sending over the full prompt but there's probably lots of edge cases around escapes in it for each shell. Just the terminator is a pretty good idea. Ive also been toying with the idea of learning what the prompt is over 3+ prompts, but the initial ones wouldn't benefit |
sergioengineer
pushed a commit
to sergioengineer/VimSCode
that referenced
this pull request
Apr 23, 2024
Make bash window prompt adjuster more strict
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210773
@cpendery since you use git bash this might impact you. Are prompts in git bash apart from a simple
$common?