Revert "Merge pull request #209136 from cpendery/fix/improve-marker-p…

[Tyriar]

…lacements"

@cpendery this broke the build unfortunately, we need to tweak it

macOS Smoke tests:

  3 failing

  1) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Shell Integration
           Process-based tests
             Decorations
               Should show default icons
                 Success:
     Error: Timeout: get elements '.terminal-command-decoration.codicon-terminal-decoration-success' after 20 seconds.
      at Code.poll (/Users/runner/work/1/s/test/automation/out/code.js:204:23)
      at async Code.waitForElements (/Users/runner/work/1/s/test/automation/out/code.js:160:16)
      at async Terminal.assertCommandDecorations (/Users/runner/work/1/s/test/automation/out/terminal.js:238:13)
      at async Context.<anonymous> (out/areas/terminal/terminal-shellIntegration.test.js:44:25)

  2) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Shell Integration
           Process-based tests
             Decorations
               Should show default icons
                 Error:
     Error: Timeout: get elements '.terminal-command-decoration.codicon-terminal-decoration-error' after 20 seconds.
      at Code.poll (/Users/runner/work/1/s/test/automation/out/code.js:204:23)
      at async Code.waitForElements (/Users/runner/work/1/s/test/automation/out/code.js:160:16)
      at async Terminal.assertCommandDecorations (/Users/runner/work/1/s/test/automation/out/terminal.js:240:13)
      at async Context.<anonymous> (out/areas/terminal/terminal-shellIntegration.test.js:49:25)

  3) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Shell Integration
           Process-based tests
             Decorations
               terminal.integrated.shellIntegration.decorationsEnabled should determine gutter and overview ruler decoration visibility
                 "before each" hook for "never":
     Error: Timeout: get elements '.terminal-command-decoration.codicon-terminal-decoration-success' after 20 seconds.
      at Code.poll (/Users/runner/work/1/s/test/automation/out/code.js:204:23)
      at async Code.waitForElements (/Users/runner/work/1/s/test/automation/out/code.js:160:16)
      at async Terminal.assertCommandDecorations (/Users/runner/work/1/s/test/automation/out/terminal.js:238:13)
      at async Context.<anonymous> (out/areas/terminal/terminal-shellIntegration.test.js:60:25)

macOS Integration tests:

8 failing
  1) vscode API - Terminal.shellIntegration
       execution events should fire in order when a command runs:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/extensions/vscode-api-tests/out/singlefolder-tests/terminal.shellIntegration.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

  2) vscode API - Terminal.shellIntegration
       end execution event should report zero exit code for successful commands:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/extensions/vscode-api-tests/out/singlefolder-tests/terminal.shellIntegration.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

  3) vscode API - Terminal.shellIntegration
       end execution event should report non-zero exit code for failed commands:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/extensions/vscode-api-tests/out/singlefolder-tests/terminal.shellIntegration.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

  4) vscode API - Terminal.shellIntegration
       TerminalShellExecution.read iterables should be available between the start and end execution events:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/extensions/vscode-api-tests/out/singlefolder-tests/terminal.shellIntegration.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

  5) vscode API - Terminal.shellIntegration
       TerminalShellExecution.read events should fire with contents of command:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/extensions/vscode-api-tests/out/singlefolder-tests/terminal.shellIntegration.test.js)
      at listOnTimeout (node:internal/timers:569:17)
      at processTimers (node:internal/timers:512:7)

  6) vscode API - Terminal.shellIntegration