[tactical] track JSPM deps in Snyk #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
tactical/track-JSPM-deps-in-snyk
branch
9 times, most recently
from
c4f5a64 to
cf9a8ea
Compare
… job to use this workaround
twrichards
force-pushed
the
tactical/track-JSPM-deps-in-snyk
branch
from
cf9a8ea to
58046c5
Compare
jonathonherbert
approved these changes
Jun 27, 2023
|
Seen on PROD (merged by @twrichards 12 minutes and 25 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/iYxnuAy1/1409-jspm
Following giving up on removing JSPM all-together (see #1520). In this PR we move all the build tooling (grunt, JSPM etc.) into
devDependencieswhere they belong.Then since Snyk can't detect JSPM dependencies, this PR introduces a workaround script which transforms the JSPM dependencies list and adds it to the top-level dependencies in a new dedicated package.json file, which the
SnykGitHub Action is now configured to use (the idea to do this is inspired by /~https://github.com/guardian/discussion-modtools/pull/812 - thanks @Mark-McCracken - although the implementation in this PR is a little simpler IMO). This looks to have had the desired effect...(rather than showing zero dependencies recognised in Snyk dashboard)