Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tactical] track JSPM deps in Snyk #1521

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[tactical] track JSPM deps in Snyk #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce636f1
move v1 deps into `devDependencies`
twrichards Jun 13, 2023
58046c5
attempt to surface JSPM dependencies in package.json and wire-up Snyk…
twrichards Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/snyk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,22 @@ on:


jobs:
security:
snyk-V2-and-scala:
uses: guardian/.github/.github/workflows/sbt-node-snyk.yml@main
with:
ORG: guardian
JAVA_VERSION: 8
EXCLUDE: package-lock.json # exclude V1, since it has its own special job below (because of JSPM)
secrets:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}

snyk-V1-only:
uses: guardian/.github/.github/workflows/sbt-node-snyk.yml@main
with:
ORG: guardian
JAVA_VERSION: 8
EXCLUDE: fronts-client # exclude V2, since it's captured by the main job above
SKIP_SBT: true # exclude scala, since it's captured by the main job above
NODE_PACKAGE_JSON_FILES_MISSING_LOCK: v1_jspm_snyk_workaround/package.json v1_jspm_snyk_workaround/result/package.json
secrets:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,5 @@ metals.sbt
.bloop
.bsp

v1_jspm_snyk_workaround/package-lock.json
v1_jspm_snyk_workaround/result
Loading