[V1] replace JSPM & Grunt with esbuild
#1520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
replace-JSPM
branch
3 times, most recently
from
f13b059 to
7d8505f
Compare
twrichards
force-pushed
the
replace-JSPM
branch
4 times, most recently
from
20e560b to
d0c7e25
Compare
twrichards
force-pushed
the
replace-JSPM
branch
2 times, most recently
from
97a7dc1 to
4865270
Compare
|
Giving up on this, so closing PR - see EDIT in PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/iYxnuAy1/1409-jspm
JSPM is a dated technology and difficult for devs to work with. It's used for V1 of facia-tool (so just config editor and breaking news notifications AFAIK) which is therefore not worked on frequently and ultimately the functionality needs to migrated to V2 (or moved into a different application).
Importantly, we have no visibility on
Ideally we'd use a simpler more modern toolchain for V1 - this PR attempts to do that.
EDIT - giving up...
I've sunk too many hours into this without being able to get things loading correctly in the browser... so cutting my losses.
Instead #1521 is a tactical measure which moves all the build tooling (grunt, JSPM etc.) into devDependencies where they belong and adds a workaround to surface the JSPM deps. in Snyk.