Fix offline store (tz-naive & field_mapping issues) #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsotnet
force-pushed
the
fix-offline-store
branch
from
4fd7dd7 to
bbca3c5
Compare
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
tsotnet
force-pushed
the
fix-offline-store
branch
from
bbca3c5 to
913cfc7
Compare
jklegar
reviewed
Apr 14, 2021
| ) | ||
|
|
||
| fv = get_feature_view(bigquery_source) | ||
| e = Entity( | ||
| name="driver_id", | ||
| description="id for driver", | ||
| join_key="driver_ident", |
There was a problem hiding this comment.
this tests that things still work when the join_key is different from the name of the entity (although it should probably be in its own separate test) so can we keep it in?
jklegar
reviewed
Apr 14, 2021
| ).to_dict() | ||
| assert abs(response_dict[f"{fv.name}__value"][0] - expected_value) < 1e-6 | ||
|
|
||
| # Check offline store |
There was a problem hiding this comment.
we do have sdk/python/tests/test_historical_retrieval.py - this works but it may be more natural to cover the field mapping cases there?
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
tsotnet
force-pushed
the
fix-offline-store
branch
from
25ceede to
8d7d710
Compare
|
/lgtm |
jklegar
approved these changes
Apr 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Discovered 2 different bugs in get_historical_features. 1) if the entity_df contains tz-naive timestamps, point-in-time merging doesn't work in local mode. 2) field_mapping is not being used in offline mode (it's used in online mode). Meaning that if you define field_mapping, get_historical_features simply fails in both local and gcp modes.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: