Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable experimental features #2774

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 2, 2020

replaces / closes #1355
fixes #947

The CLI disabled experimental features by default, requiring users to set a configuration option to enable them.

Disabling experimental features was a request from Enterprise users that did not want experimental features to be accessible.

We are changing this policy, and now enable experimental features by default. Experimental features may still change and/or removed, and will be highlighted in the documentation and "usage" output.

For example, the docker manifest inspect --help output now shows:

EXPERIMENTAL:
  docker manifest inspect is an experimental feature.

  Experimental features provide early access to product functionality. These features
  may change between releases without warning or can be removed entirely from a future
  release. Learn more about experimental features: https://docs.docker.com/go/experimental/

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

cli-plugins/manager/metadata.go Outdated Show resolved Hide resolved
kubernetes/check.go Outdated Show resolved Hide resolved
kubernetes/check.go Outdated Show resolved Hide resolved
@thaJeztah thaJeztah force-pushed the drop_experimental branch 2 times, most recently from 48d4970 to 3f612d9 Compare October 2, 2020 12:39
@thaJeztah

This comment has been minimized.

@thaJeztah thaJeztah force-pushed the drop_experimental branch 2 times, most recently from 0d9e669 to 60a8584 Compare October 2, 2020 13:28
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

Merging #2774 into master will decrease coverage by 0.00%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #2774      +/-   ##
==========================================
- Coverage   57.15%   57.14%   -0.01%     
==========================================
  Files         297      297              
  Lines       18656    18634      -22     
==========================================
- Hits        10662    10649      -13     
+ Misses       7132     7126       -6     
+ Partials      862      859       -3     

The CLI disabled experimental features by default, requiring users
to set a configuration option to enable them.

Disabling experimental features was a request from Enterprise users
that did not want experimental features to be accessible.

We are changing this policy, and now enable experimental features
by default. Experimental features may still change and/or removed,
and will be highlighted in the documentation and "usage" output.

For example, the `docker manifest inspect --help` output now shows:

    EXPERIMENTAL:
      docker manifest inspect is an experimental feature.

      Experimental features provide early access to product functionality. These features
      may change between releases without warning or can be removed entirely from a future
      release. Learn more about experimental features: https://docs.docker.com/go/experimental/

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

FWIW, I preserved the Experimental: true in the output of docker version. It's likely that there are scripts that use this output to check if the cli is configured with experimental features, and we don't want to break those (we could mark that output as deprecated as well, and remove it at some point though)

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 6916b42 into docker:master Oct 2, 2020
@thaJeztah thaJeztah deleted the drop_experimental branch October 2, 2020 15:36
albers added a commit to albers/docker-cli that referenced this pull request Nov 10, 2020
This amends docker#2774 for bash completion.

Signed-off-by: Harald Albers <github@albersweb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker manifest commands don't work on 18.03.0-ce-rc3
4 participants