cli-plugins/manager: fix deprecation comment of Metadata.Experimental #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was marked deprecated in 977d3ae, which is part of v20.10 and up, but the comment was missing a newline before the deprecation message, which may be picked up by IDEs, but is not matching the correct format, so may not be picked up by linters. This patch fixes the format, to make sure linters pick up that the field is deprecated. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced May 9, 2023
rumpl
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was marked deprecated in 977d3ae (#2774), which is part of v20.10 and up, but the comment was missing a newline before the deprecation message, which may be picked up by IDEs, but is not matching the correct format, so may not be picked up by linters.
This patch fixes the format, to make sure linters pick up that the field is deprecated.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)