Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable experimental features in bash completion #2837

Merged

Conversation

albers
Copy link
Collaborator

@albers albers commented Nov 10, 2020

This amends #2774 for bash completion.

docker manifest now ist always completed.

The previous state parsed the output of docker version to determine the cli experimental state.

This amends docker#2774 for bash completion.

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thanks; I completely forgot 😞

@thaJeztah
Copy link
Member

Failure is unrelated;

cli/command/container/stats.go:159: File is not `goimports`-ed (goimports)

will be fixed by #2836

@thaJeztah thaJeztah added this to the 20.10.0 milestone Nov 10, 2020
@thaJeztah thaJeztah merged commit 92516c7 into docker:master Nov 10, 2020
@albers albers deleted the completion-remove-experimental-client branch November 11, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants