Fix environment variable definitions for registry viewer deployment #30
Conversation
…er using the registry operator. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
| Value: fmt.Sprintf(`[{\"name\":\"Community\",\"url\":\"http://localhost:8080\",\"fqdn\":\"http://%s.%s\"}]`, | ||
| IngressName(cr.Name), cr.Spec.K8s.IngressDomain), |
There was a problem hiding this comment.
Are you planning to update the fqdn to cr.Status.URL in a different PR?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Operator deployment failed during testing, moving to WIP till resolved. |
michael-valdron
changed the title
michael-valdron
changed the title
|
/retest |
|
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
No longer needed, #29 has this fix. |
Signed-off-by: Michael Valdron mvaldron@redhat.com
Please specify the area for this PR
operator
What does does this PR do / why we need it:
Provides required fixes to setting environment variables on the registry viewer within the registry operator deployment.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1016
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: