Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry viewer environment variables not being properly set #1016

Closed
michael-valdron opened this issue Jan 30, 2023 · 0 comments · Fixed by devfile/registry#156 or devfile/registry-operator#29
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Jan 30, 2023

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

Go project

Operating System and version: RHEL 8.7

Go Pkg Version: 1.17

Node.js project

Operating System and version:

Node.js version: 16

Yarn version: 1.22.19

Project.json:

Bug Summary

Describe the bug:

Currently, the environment variables for the registry viewer are being set under a mounted envfile /app/apps/registry-viewer/.env.local. It should be set under a mounted envfile /app/.env.production, in addition the environment variables needs to be loaded on deployment in the template spec rather than just loaded from the envfile by Next.js.

blocks #1006, #1014

To Reproduce:

Deployment using the current OpenShift template specs and registry operator.

Expected behavior

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Additional context

Any workaround?

None.

Suggestion on how to fix the bug

Environment variables need to be set in both the mounted envfile and in the deployment spec.

Target Date: 02-09-2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment