Deployment bugfixes

[michael-valdron]

Please specify the area for this PR

operator bugfix

What does does this PR do / why we need it:

Bugfix changes include:

• Removes unnecessary escape characters used on pkg/registry/configmap.go#L55 which cause the registry viewer to fail the JSON parsing process and fail to deploy.
• Changes for Registry viewer environment variables not being properly set api#1016 applied.
• Changes for Registry viewer container quietly restarting api#1019 applied.
• Adds container security contexts required by OCP 4.12.
• Add pod security contexts if storage is enabled.
• Makefile now lets user override the K8S_CLI variable.
• Missing registryViewerWriteKey added to the devfile registries crd config.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#966, devfile/api#1014, devfile/api#1016, devfile/api#1019, devfile/api#1025

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: /~https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to updated with your changes?

How to test changes / Special notes to the reviewer:

[codecov]

Codecov Report

Base: 24.28% // Head: 22.01% // Decreases project coverage by -2.28% ⚠️

Coverage data is based on head (73f7260) compared to base (07d69b2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   24.28%   22.01%   -2.28%     
==========================================
  Files          22       22              
  Lines        1054     1163     +109     
==========================================
  Hits          256      256              
- Misses        789      898     +109     
  Partials        9        9              

Impacted Files	Coverage Δ
api/v1alpha1/devfileregistry_types.go	100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go	26.22% <0.00%> (-0.60%)	⬇️
controllers/update.go	0.00% <0.00%> (ø)
pkg/registry/configmap.go	0.00% <0.00%> (ø)
pkg/registry/defaults.go	59.18% <0.00%> (-15.18%)	⬇️
pkg/registry/deployment.go	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kim-tsao]

The fqdn format will not work on openshift deployments since the IngressDomain is only required for Kubernetes deployment and it can be empty. If a registry is successfully deployed it should update the URL in cr.Status.URL field so we can rely on that setting as long as it's not empty.

[michael-valdron]

Blocked, needs rebasing to changes in #30 and #31.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment