dependency: update dependency signal-exit to v3.0.7 #28979
Conversation
![renovate[bot]](/~https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
renovate
bot
force-pushed
the
renovate/signal-exit-3.x
branch
from
972c588 to
c4bb516
Compare
…-io/cypress into renovate/signal-exit-3.x
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Passing run #54304 ↗︎
Details:
Review all test suite changes for PR #28979 ↗︎ |
|||||||||||||||
jennifer-shehane
changed the title
| @@ -115,7 +115,7 @@ | |||
| "semver": "7.3.2", | |||
| "send": "0.17.1", | |||
| "shell-env": "3.0.1", | |||
| "signal-exit": "3.0.3", | |||
| "signal-exit": "3.0.7", | |||
There was a problem hiding this comment.
We are not directly using this dependency. It seems like this was added to be the "top-level" version reference in node_modules. We might be able to remove this...
There was a problem hiding this comment.
added in this PR: /~https://github.com/cypress-io/cypress/pull/17215/files
There was a problem hiding this comment.
@emilyrohrbough Ok, so I was removing this in this PR and the tests did pass, but then I saw it used here after fixing my vscode search: /~https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/util/exit.js
But it looks like this is actually only referenced in this test file, so should this be a devDep? /~https://github.com/cypress-io/cypress/blob/develop/packages/server/test/unit/util/file_spec.js#L31
But if it's used in our tests, how did that test ever pass? Because it's stubbed? I've gotten so confused on this one.
There was a problem hiding this comment.
Ahh it's here:
cypress/packages/server/lib/util/file.js
Line 36 in 3c0c864
There was a problem hiding this comment.
Looks like I fell victim to an outdated search from my branch being outdated. Looks like my .gitignore still included server/lib* files
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This PR contains the following updates:
3.0.3->3.0.7Release Notes
tapjs/signal-exit (signal-exit)
v3.0.7Compare Source
v3.0.6Compare Source
v3.0.5Compare Source
v3.0.4Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.