Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency signal-exit #28975

Closed
wants to merge 3 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 20, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
signal-exit 3.0.3 -> 3.0.7 age adoption passing confidence

Release Notes

tapjs/signal-exit (signal-exit)

v3.0.7

Compare Source

v3.0.6

Compare Source

v3.0.5

Compare Source

v3.0.4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@renovate renovate bot force-pushed the renovate/signal-exit-3.x branch from 058bb11 to 6626a7a Compare February 20, 2024 15:54
@renovate renovate bot force-pushed the renovate/signal-exit-3.x branch from 6626a7a to cc4fcc3 Compare February 20, 2024 16:31
@jennifer-shehane jennifer-shehane changed the title fix(deps): update dependency signal-exit to v3.0.7 chore: remove dependency signal-exit Feb 20, 2024
@jennifer-shehane jennifer-shehane self-assigned this Feb 20, 2024
Copy link
Contributor Author

renovate bot commented Feb 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

cypress bot commented Feb 20, 2024

7 flaky tests on run #54099 ↗︎

0 28947 1341 0 Flakiness 7

Details:

empty commit
Project: cypress Commit: 6f15796765
Status: Passed Duration: 18:58 💡
Started: Feb 20, 2024 5:31 PM Ended: Feb 20, 2024 5:50 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws after timing out after a .wait() alias reference Test Replay
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
network stubbing > waiting and aliasing > can spy on a 304 not modified image response
    </td>
  </tr></table>
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary
    </td>
  </tr></table>
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > can timeout when retrieving upstream response Test Replay

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #28975 ↗︎

@jennifer-shehane jennifer-shehane self-requested a review February 20, 2024 21:27
@jennifer-shehane
Copy link
Member

signal-exit is not used in the server at all, so can be safely removed instead of bumped up as a dep.

@alexsch01
Copy link
Contributor

@jennifer-shehane I think you closed the wrong PR

@jennifer-shehane
Copy link
Member

It actually is used in the server. There was an issue with the search in our local code editors due to the server lib being incorrectly included in gitignore. #28977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants