Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update dependency signal-exit to v3.0.7 #28979

Merged
merged 11 commits into from
Mar 1, 2024
+2 −6
Merged

dependency: update dependency signal-exit to v3.0.7 #28979

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cc4fcc3
fix(deps): update dependency signal-exit to v3.0.7
renovate[bot] Feb 20, 2024
9d4f219
Remove signal-exit - this is not used
jennifer-shehane Feb 20, 2024
6f15796
empty commit
jennifer-shehane Feb 20, 2024
c4bb516
fix(deps): update dependency signal-exit to v3.0.7
renovate[bot] Feb 21, 2024
823b6e3
Merge branch 'renovate/signal-exit-3.x' of /~https://github.com/cypress…
jennifer-shehane Feb 21, 2024
08c4f70
Merge branch 'develop' into renovate/signal-exit-3.x
jennifer-shehane Feb 22, 2024
59f7489
Merge branch 'develop' into renovate/signal-exit-3.x
jennifer-shehane Feb 27, 2024
9b5ced4
Update changelog
jennifer-shehane Feb 27, 2024
d7cad18
Update cli/CHANGELOG.md
emilyrohrbough Feb 27, 2024
7507394
Merge branch 'develop' into renovate/signal-exit-3.x
ryanthemanuel Feb 28, 2024
4adc86d
Merge branch 'develop' into renovate/signal-exit-3.x
jennifer-shehane Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ _Released 2/27/2024 (PENDING)_
- Fixed an issue where `.click()` commands on children of disabled elements would still produce "click" events -- even without `{ force: true }`. Fixes [#28788](/~https://github.com/cypress-io/cypress/issues/28788).
- Changed RequestBody type to allow for boolean and null literals to be passed as body values. [#28789](/~https://github.com/cypress-io/cypress/issues/28789)

**Dependency Updates:**

- Updated signal-exit from `3.0.3` to `3.0.7`. Addressed in [#28979](/~https://github.com/cypress-io/cypress/pull/28979).

## 13.6.6

_Released 2/22/2024_
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"semver": "7.3.2",
"send": "0.17.1",
"shell-env": "3.0.1",
"signal-exit": "3.0.3",
"signal-exit": "3.0.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not directly using this dependency. It seems like this was added to be the "top-level" version reference in node_modules. We might be able to remove this...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in this PR: /~https://github.com/cypress-io/cypress/pull/17215/files

Copy link
Member

@jennifer-shehane jennifer-shehane Feb 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilyrohrbough Ok, so I was removing this in this PR and the tests did pass, but then I saw it used here after fixing my vscode search: /~https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/util/exit.js

But it looks like this is actually only referenced in this test file, so should this be a devDep? /~https://github.com/cypress-io/cypress/blob/develop/packages/server/test/unit/util/file_spec.js#L31

But if it's used in our tests, how did that test ever pass? Because it's stubbed? I've gotten so confused on this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh it's here:

cypress/packages/server/lib/util/file.js

Line 36 in 3c0c864

exit.ensure(() => {

Copy link
Member

@emilyrohrbough emilyrohrbough Feb 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I fell victim to an outdated search from my branch being outdated. Looks like my .gitignore still included server/lib* files

"squirrelly": "7.9.2",
"strip-ansi": "6.0.0",
"syntax-error": "1.4.0",
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27385,11 +27385,6 @@ sigmund@^1.0.1, sigmund@~1.0.0:
resolved "https://registry.yarnpkg.com/sigmund/-/sigmund-1.0.1.tgz#3ff21f198cad2175f9f3b781853fd94d0d19b590"
integrity sha1-P/IfGYytIXX587eBhT/ZTQ0ZtZA=

signal-exit@3.0.3:
version "3.0.3"
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.3.tgz#a1410c2edd8f077b08b4e253c8eacfcaf057461c"
integrity sha512-VUJ49FC8U1OxwZLxIbTTrDvLnf/6TDgxZcK8wxR8zs13xpx7xbG60ndBlhNrFi2EMuFRoeDoJO7wthSLq42EjA==

signal-exit@3.0.7, signal-exit@^3.0.0, signal-exit@^3.0.2, signal-exit@^3.0.3, signal-exit@^3.0.7:
version "3.0.7"
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.7.tgz#a9a1767f8af84155114eaabd73f99273c8f59ad9"
Expand Down
Loading