Add no_std support to bevy_hierarchy
#16998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Feature
BenjaminBrienen
approved these changes
Dec 27, 2024
| @@ -8,7 +8,7 @@ use bevy_ecs::{ | |||
| system::EntityCommands, | |||
| world::{Command, DeferredWorld, EntityWorldMut, World}, | |||
| }; | |||
| use bevy_utils::tracing::debug; | |||
| use log::debug; | |||
There was a problem hiding this comment.
Why is log necessary if we have tracing?
There was a problem hiding this comment.
tracing doesn't work on certain platforms if they don't support atomic CAS, whereas log works on every platform. Most notable example is Raspberry Pi Pico and other embedded ARM CPUs.
alice-i-cecile
approved these changes
Dec 29, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Contributes to bevyengine#15460 ## Solution - Added the following features: - `std` (default) ## Testing - CI ## Notes - There was a minor issue with `bevy_reflect`'s `smallvec` feature noticed in this PR which I have also resolved here. I can split this out if desired, but I've left it here for now as it's a very small change and I don't consider this PR itself to be very controversial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_stdBevy #15460Solution
std(default)Testing
Notes
bevy_reflect'ssmallvecfeature noticed in this PR which I have also resolved here. I can split this out if desired, but I've left it here for now as it's a very small change and I don't consider this PR itself to be very controversial.