Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add new Maven build for Scala package #13819

Merged
merged 5 commits into from
Jan 10, 2019
Merged

Add new Maven build for Scala package #13819

merged 5 commits into from
Jan 10, 2019

Conversation

lanking520
Copy link
Member

Description

This PR is a follow up with @frankfliu PR to add maven run configurations. We also enabled MKLDNN unit test run on Scala
@frankfliu @marcoabreu @zachgk @andrewfayres @piyushghai

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review, Scala]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Jan 9, 2019
zachgk
zachgk suggested changes Jan 9, 2019
View reviewed changes
ci/docker/runtime_functions.sh Outdated Show resolved Hide resolved
ci/jenkins/Jenkins_steps.groovy Show resolved Hide resolved
scala-package/spark/README.md Outdated Show resolved Hide resolved
tests/jenkins/run_test_amzn_linux_gpu.sh Outdated Show resolved Hide resolved
piyushghai
piyushghai reviewed Jan 9, 2019
View reviewed changes
contrib/clojure-package/README.md
make scalapkg
make scalainstall
cd scala-package
mvn install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather make is : mvn clean install

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a new user tutorial, I think it should be fine to just do install

piyushghai
piyushghai reviewed Jan 9, 2019
View reviewed changes
scala-package/spark/README.md
@@ -17,7 +17,7 @@ Compile the Scala Package by

```bash
cd scala-package
mvn install
mvn package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it from install to package ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachgk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. This seems fine.

zachgk
zachgk suggested changes Jan 9, 2019
View reviewed changes
tests/jenkins/run_test_amzn_linux_gpu.sh Outdated Show resolved Hide resolved
piyushghai
piyushghai approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements!
LGTM

gigasquid
gigasquid approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the Clojure side of things

andrewfayres
andrewfayres approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@andrewfayres andrewfayres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 5fe2172 into apache:master Jan 10, 2019
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Jan 11, 2019
@zhaoyao73
Merge remote-tracking branch 'upstream/master'
7c21b53 
* upstream/master: (109 commits)
  Code modification for  testcases of various network models in directory example (apache#12498)
  [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818)
  fix Makefile for rpkg (apache#13590)
  change to compile time (apache#13835)
  Disabled flaky test (apache#13758)
  Improve license_header tool by only traversing files under revision c… (apache#13803)
  Removes unneeded nvidia driver ppa installation (apache#13814)
  Add Local test stage and option to jump directly to menu item from commandline (apache#13809)
  Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830)
  Fix scala doc build break for v1.3.1 (apache#13820)
  [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794)
  [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678)
  onnx export ops (apache#13821)
  [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676)
  fix minor indentation (apache#13827)
  Fixing a symlink issue with R install (apache#13708)
  remove useless code (apache#13777)
  ONNX ops: norm exported and lpnormalization imported (apache#13806)
  Add new Maven build for Scala package (apache#13819)
  Dockerfiles for Publish Testing (apache#13707)
  ...
@lanking520 lanking520 deleted the scalabuild branch March 11, 2019 22:29
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@lanking520
Add new Maven build for Scala package (apache#13819)
d0d22b4 
* clean up build

* fix minor issue and add mkldnn

* fix mx_dist problem

* fix clojure build

* fix skip test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewfayres andrewfayres andrewfayres approved these changes

@piyushghai piyushghai piyushghai approved these changes

@zachgk zachgk zachgk approved these changes

@gigasquid gigasquid gigasquid approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lanking520 @anirudhacharya @gigasquid @zachgk @piyushghai @andrewfayres @marcoabreu