Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs #13794

Merged
merged 7 commits into from
Jan 10, 2019
Merged

[MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs #13794

merged 7 commits into from
Jan 10, 2019

Conversation

piyushghai
Copy link
Contributor

@piyushghai piyushghai commented Jan 8, 2019 •
edited
Loading

Description

Added unit tests for Java Predictor API and Object Detector API.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 @andrewfayres @zachgk

@vishaalkapoor
Copy link
Contributor

LGTM

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review, Java]

@marcoabreu marcoabreu added Java Label to identify Java API component pr-awaiting-review PR is waiting for code review labels Jan 9, 2019
zachgk
zachgk reviewed Jan 10, 2019
View reviewed changes
scala-package/core/pom.xml Outdated Show resolved Hide resolved
lanking520
lanking520 approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 17836f5 into apache:master Jan 10, 2019
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Jan 11, 2019
@zhaoyao73
Merge remote-tracking branch 'upstream/master'
7c21b53 
* upstream/master: (109 commits)
  Code modification for  testcases of various network models in directory example (apache#12498)
  [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818)
  fix Makefile for rpkg (apache#13590)
  change to compile time (apache#13835)
  Disabled flaky test (apache#13758)
  Improve license_header tool by only traversing files under revision c… (apache#13803)
  Removes unneeded nvidia driver ppa installation (apache#13814)
  Add Local test stage and option to jump directly to menu item from commandline (apache#13809)
  Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830)
  Fix scala doc build break for v1.3.1 (apache#13820)
  [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794)
  [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678)
  onnx export ops (apache#13821)
  [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676)
  fix minor indentation (apache#13827)
  Fixing a symlink issue with R install (apache#13708)
  remove useless code (apache#13777)
  ONNX ops: norm exported and lpnormalization imported (apache#13806)
  Add new Maven build for Scala package (apache#13819)
  Dockerfiles for Publish Testing (apache#13707)
  ...
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@piyushghai
[MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (a…
2302420 
…pache#13794)

* Added unit tests for Predictor API in Java

* Added unit tests for ObjectDetectorOutput

* Added unit tests for ObjectDetector API in Java

* Addressed PR comments

* Added Maven SureFire plugin to run the Java UTs

* Pom file clean up -- moved surefire plugin to parent pom.xml

* Renamed skipTests to SkipJavaTests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vishaalkapoor vishaalkapoor vishaalkapoor left review comments

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk zachgk approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
Java Label to identify Java API component pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piyushghai @vishaalkapoor @anirudhacharya @zachgk @lanking520 @marcoabreu