Fixing a symlink issue with R install #13708
Conversation
|
@ankkhedia @anirudhacharya - please take a look. |
|
@aaronmarkham you may want to merge this one... |
docs/install/index.md
Outdated
| @@ -703,7 +703,7 @@ brew install openblas@0.3.1 | |||
| Add a soft link to the OpenBLAS installation. This example links the 0.3.1 version: | |||
|
|
|||
| ```bash | |||
| ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.* /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib | |||
| ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.*.dylib /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib | |||
There was a problem hiding this comment.
@ankkhedia @anirudhacharya why openblas@0.3.1? there are bug fixes/performance improvements post this version /~https://github.com/xianyi/OpenBLAS/releases
Usually you create symlink without the version to a specific version something like this. if there are multiple 0.3* version, the command fails
ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib /usr/local/opt/openblas/lib/libopenblasp.dylib
``
There was a problem hiding this comment.
it picks up the BLAS version from the machine where the R-package was built. We explored not hard-linking to a particular BLAS version, but that is not trivial. Will revisit it again. Either ways, this PR need not be blocked because of that right?
|
@mxnet-label-bot Add [R, pr-awaiting-response] |
marcoabreu
added
pr-awaiting-response
|
@ankkhedia @anirudhacharya - can you please take a look at Naveen's comment? |
@lupesko Can you check the response regarding targeting a specific version? LMK if that's resolved or not. |
|
Had a discussion with @nswamy and @anirudhacharya and we agreed to update it so that user installs the latest openblas and we symbolically link it with whatever version they have. PR update to follow. |
|
@lupesko is this ready to ship? |
* upstream/master: (109 commits) Code modification for testcases of various network models in directory example (apache#12498) [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818) fix Makefile for rpkg (apache#13590) change to compile time (apache#13835) Disabled flaky test (apache#13758) Improve license_header tool by only traversing files under revision c… (apache#13803) Removes unneeded nvidia driver ppa installation (apache#13814) Add Local test stage and option to jump directly to menu item from commandline (apache#13809) Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830) Fix scala doc build break for v1.3.1 (apache#13820) [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794) [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678) onnx export ops (apache#13821) [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676) fix minor indentation (apache#13827) Fixing a symlink issue with R install (apache#13708) remove useless code (apache#13777) ONNX ops: norm exported and lpnormalization imported (apache#13806) Add new Maven build for Scala package (apache#13819) Dockerfiles for Publish Testing (apache#13707) ...
Description
Fixing a symlink issue with R install, which prevents the R install instructions from working as expected.
Verified that the fix is working.