add Max strategy for sequence_pool op #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luotao1
commented
Oct 17, 2017
luotao1
commented
- solve part2 of Add sequence_pool op #4186
- simplify test_pool_py
- add comments for different pooling strategies. add SQRT/LAST/FIRST strategy for Seqpool #4788 (review)
36 tasks
6 tasks
qingqing01
reviewed
Oct 20, 2017
paddle/operators/sequence_pool_op.h
Outdated
| case MAX: { | ||
| auto in_t = in->Slice<T>(static_cast<int>(lod[i]), | ||
| static_cast<int>(lod[i + 1])); | ||
| auto out_t = out->Slice<T>(i, i + 1); |
There was a problem hiding this comment.
Need to update code, the Slice remove the template T: /~https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/framework/tensor.h#L124
paddle/operators/sequence_pool_op.h
Outdated
| auto ones = in_g_e.constant(1); | ||
| auto zeros = in_g_e.constant(0); | ||
| in_g_e.device(place) = | ||
| out_g_e.broadcast(bcast) * equals.select(ones, zeros); |
There was a problem hiding this comment.
It's better to keep the same way with the MaxSeqPool in the old framework, which records the max indexes in the forward and uses them in the backward. Since there may be multiple maximum values.
There was a problem hiding this comment.
Done. 在反向中采用maxCoeff函数，获得每列中的第一个最大值。
考虑到inference的效率，保持前向不变，maxCoeff加在反向中。
目前实现的版本性能上还有待优化，等之后的PR修复。
qingqing01
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.