add SQRT/LAST/FIRST strategy for Seqpool #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
changed the title
36 tasks
qingqing01
reviewed
Oct 16, 2017
paddle/operators/sequence_pool_op.cc
Outdated
| AddOutput( | ||
| "Out", | ||
| "A float LoDTensor, the variable-length output of SequencePoolOp."); | ||
| AddInput("X", "A LoDTensor, the variable-length input of SequencePoolOp"); |
There was a problem hiding this comment.
AddInput("X",
"(LoDTensor), the variable-length input of SequencePoolOp");
paddle/operators/sequence_pool_op.cc
Outdated
| "A float LoDTensor, the variable-length output of SequencePoolOp."); | ||
| AddInput("X", "A LoDTensor, the variable-length input of SequencePoolOp"); | ||
| AddOutput("Out", | ||
| "A LoDTensor, the variable-length output of SequencePoolOp."); |
There was a problem hiding this comment.
AddOutput("Out",
"(Tensor), the output of SequencePoolOp is a Tensor, which does not contain LoD infomation.");这里支持双层吗？ 输出还变长吗？
There was a problem hiding this comment.
Done。由于目前还没写到双层，这里先修改成Tensor。等以后加入双层特征后，再对应修改注释。
paddle/operators/sequence_pool_op.h
Outdated
| @@ -98,6 +109,10 @@ class SequencePoolGradKernel : public framework::OpKernel<T> { | |||
| int64_t w = in->numel() / dims[0]; | |||
|
|
|||
| in_g->mutable_data<T>(context.GetPlace()); | |||
| if (strategy > 2) { | |||
There was a problem hiding this comment.
if ( strategy == LAST || strategy == FIRST || strategy == MAX) {
// ..
}There was a problem hiding this comment.
Done。Max的时候，也不需要先置0.（处理方式见下一个PR）
qingqing01
approved these changes
Oct 16, 2017
|
I will add more explanation in next PR. |
This was referenced Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve part2 of #4186
MAX strategy will be in next PR.