Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ActionableMessage in Advanced Tab #20900

Conversation

pritam1813
Copy link
Contributor

Explanation

Screenshots/Screencaps

Before

before_success
before_danger

After

after_success
after_danger

Manual Testing Steps

  • Create build from this PR
  • From Menu go to Settings -> Advanced
  • Scroll Down to find Restore user data section.
  • Try Restoring with proper/corrupted file.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@pritam1813 pritam1813 requested a review from a team as a code owner September 15, 2023 10:40
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Sep 16, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @pritam1813! I've updated the e2e test to use a data test id which should help with e2e test failures. I have one question what JSON file did you use to show the corrupt version of the banner? Once I can test that I can approve

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f315a2b) 68.17% compared to head (56865cd) 68.16%.
Report is 52 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20900      +/-   ##
===========================================
- Coverage    68.17%   68.16%   -0.01%     
===========================================
  Files          998      998              
  Lines        39966    39967       +1     
  Branches     10686    10687       +1     
===========================================
- Hits         27243    27241       -2     
- Misses       12723    12726       +3     
Files Changed Coverage Δ
...es/settings/advanced-tab/advanced-tab.component.js 59.39% <0.00%> (-0.36%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pritam1813
Copy link
Contributor Author

pritam1813 commented Sep 23, 2023

This looks great @pritam1813! I've updated the e2e test to use a data test id which should help with e2e test failures. I have one question what JSON file did you use to show the corrupt version of the banner? Once I can test that I can approve

Thanks @georgewrmarshall for updating the e2e tests.

For the corrupt version of the Banner, I first created a backup from the "Backup your data" option , which gives a backup json file.
Screenshot from 2023-09-23 15-07-04

Then I just edited that file to add improper formatting for json (like adding extra bracket or comma), which would make it a corrupted backup data.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

  • pulled branch and checked locally with compatible json and corrupt json file

@garrettbear garrettbear merged commit cffa262 into MetaMask:develop Oct 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants