-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced ActionableMessage in Advanced Tab #20900
Replaced ActionableMessage in Advanced Tab #20900
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…n in Advanced settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @pritam1813! I've updated the e2e test to use a data test id which should help with e2e test failures. I have one question what JSON file did you use to show the corrupt version of the banner? Once I can test that I can approve
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #20900 +/- ##
===========================================
- Coverage 68.17% 68.16% -0.01%
===========================================
Files 998 998
Lines 39966 39967 +1
Branches 10686 10687 +1
===========================================
- Hits 27243 27241 -2
- Misses 12723 12726 +3
☔ View full report in Codecov by Sentry. |
Thanks @georgewrmarshall for updating the e2e tests. For the corrupt version of the Banner, I first created a backup from the "Backup your data" option , which gives a backup json file. Then I just edited that file to add improper formatting for json (like adding extra bracket or comma), which would make it a corrupted backup data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
- pulled branch and checked locally with compatible json and corrupt json file
Explanation
ActionableMessage
withBannerAlert
inui/pages/settings/advanced-tab/advanced-tab.component.js
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.