Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{is} prepare for rsem #609

Merged
merged 7 commits into from
Nov 16, 2023
Merged

{is} prepare for rsem #609

merged 7 commits into from
Nov 16, 2023

Conversation

IanSudbery
Copy link
Member

Add new command that allows UMI-tools output to be used with tools that expect pairs to be adjacent to each other in the output, such as RSEM and salmon.

IanSudbery and others added 7 commits March 28, 2021 19:39
prepare-for-rsem tries to identify cases where a read has no mate by catching a look up error. However, the wrong exception type was specified. Since current template is a dictionary of defaultdicts, it shouldn't throw a key error. However the returned list will be empty, so any attempt to index into it will throw an IndexError.
@IanSudbery
Copy link
Member Author

Fix for #607. This was a branch that was created against 1.1.2, but never integrated into the main trunk.

@IanSudbery IanSudbery merged commit 6c398af into master Nov 16, 2023
3 checks passed
@pinin4fjords
Copy link

Will there be a release soon to include this?

@TomSmithCGAT
Copy link
Member

@pinin4fjords - yes! It looks like the last release (v1.1.4) is now close to a year behind the github repo.

I'll sort this very soon. I've left Ian to man the ship all by himself for almost all that time so I'll need to aquaint myself with the any updates first.

@TomSmithCGAT
Copy link
Member

@pinin4fjords - 1.1.5 has now been released on github. I'll check back on bioconda later when the BiocondaBot has had a chance to try and update.

@pinin4fjords
Copy link

Great- thanks @TomSmithCGAT !

@pinin4fjords
Copy link

Merged! bioconda/bioconda-recipes#45795

(I fixed a minor linting issue)

@TomSmithCGAT
Copy link
Member

Thanks @pinin4fjords. For my own education, what is the run_export doing?

@pinin4fjords
Copy link

See https://bioconda.github.io/contributor/linting.html#missing-run-exports

Obviously feel free to tweak for future builds :-)

@TomSmithCGAT TomSmithCGAT deleted the {IS}_prepare-for-rsem branch October 3, 2024 09:27
@TomSmithCGAT TomSmithCGAT restored the {IS}_prepare-for-rsem branch October 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants