-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umitools prepareforrsem #4897
Merged
Merged
Umitools prepareforrsem #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinin4fjords
requested review from
Joon-Klaps
and removed request for
a team
February 12, 2024 17:00
…modules into umitools_prepareforrsem
maxulysse
reviewed
Feb 13, 2024
maxulysse
reviewed
Feb 13, 2024
maxulysse
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Thanks @maxulysse ! |
jch-13
pushed a commit
to jch-13/modules
that referenced
this pull request
Mar 19, 2024
* Add umitools/prepareforrsem * Remove trailing newlines * Fix software env * appease eclint * fix linting * fix comment * Don't snapshot python version * Readd snapshot file * Apply suggestions from code review Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com> --------- Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* Add umitools/prepareforrsem * Remove trailing newlines * Fix software env * appease eclint * fix linting * fix comment * Don't snapshot python version * Readd snapshot file * Apply suggestions from code review Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com> --------- Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding UMI tools' prepare for rsem script. This will be a native command in the next release of UMI tools, but for now I'm bundling the python with the module as a template.
See:
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware