Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in Beta #473

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Update dependencies in Beta #473

merged 4 commits into from
Jul 10, 2019

Conversation

pradeepnschrodinger
Copy link
Collaborator

@pradeepnschrodinger pradeepnschrodinger commented Jul 9, 2019 •
edited
Loading

Description

Redone all the steps for updating the dependencies

Motivation and Context

Fixes SS-25810

How Has This Been Tested?

Tested on LD and site examples.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@pradeepnschrodinger
Initial Update
2c931c3 
* `postcss` updated
* HMR for CSS
* `mini-css-extract-plugin` replaces `extract-text-webpack-plugin`
* `webpack` updated to v4
* other packages updated
@pradeepnschrodinger
Babel upgrade
5c75b49 
* Upgraded to Babel v7
* Calypso codemods ran `calypso-codemods commonjs-imports,commonjs-exports ./src ./examples`
@pradeepnschrodinger pradeepnschrodinger changed the base branch from master to v1.0-beta July 9, 2019 13:36
@pradeepnschrodinger
Copy link
Collaborator Author

The tests seem to be failing meh 🤔
I think we'll have to apply the codemods on the test folder.

wcjordan
wcjordan approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@wcjordan wcjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for slogging through these changes.

Let me know if anything novel comes up while modifying the tests.

@pradeepnschrodinger
Fix tests
97429c5 
* FixedDataTableRoot-test used a default styled import on a non-default styled export
@pradeepnschrodinger
Remove unneeded packages
28f889a 
* Removed `updtr` and `calypso-codemods` which were only used for the update process
@pradeepnschrodinger
Copy link
Collaborator Author

lgtm. Thanks for slogging through these changes.

Let me know if anything novel comes up while modifying the tests.

Thanks, got the tests working by 97429c5. What happened was that a test file was using a default styled import over FixedDataTableRoot.js
But it doesn't use a default export.

I also removed updtr and calypso-codemods since they're no longer needed.

I'll keep this review open for 1 more day before merging and cutting a release.

@wcjordan
Copy link
Member

wcjordan commented Jul 10, 2019 •
edited
Loading

Great, thanks! lgtm

@pradeepnschrodinger pradeepnschrodinger merged commit f1d4ff9 into v1.0-beta Jul 10, 2019
@pradeepnschrodinger pradeepnschrodinger deleted the beta-update-dependencies-squash branch July 15, 2019 20:18
@pradeepnschrodinger pradeepnschrodinger mentioned this pull request Sep 12, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcjordan wcjordan wcjordan approved these changes

@somavara somavara Awaiting requested review from somavara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradeepnschrodinger @wcjordan