Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility support for a screen reader (i.e. JAWS or Narrator) #440

Closed
Tanner-MS opened this issue May 4, 2019 · 2 comments
Closed

Accessibility support for a screen reader (i.e. JAWS or Narrator) #440

Tanner-MS opened this issue May 4, 2019 · 2 comments
Labels
enhancement help wanted

Comments

@Tanner-MS
Copy link
Contributor

Accessibility tree should be correct so a screen reader can understand DOM structure. Currently there are no roles set anywhere.
This can be achieved by adding the correct roles and attributes to the elements following the ARIA standard. Here is a link: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Grid_Role

This is needed for users with disabilities to be able to use this control.
@wcjordan
Copy link
Member

wcjordan commented May 4, 2019

Hey @Tanner-MS, thanks for filing this. We'd be happy to accept a PR adding this.

@Tanner-MS Tanner-MS mentioned this issue May 14, 2019
Merged
7 tasks
pradeepnschrodinger pushed a commit that referenced this issue May 21, 2019
@Tanner-MS @pradeepnschrodinger
Add roles and aria-attributes for initial screen reader support (#445)…
4a738f1 
… (Helps #440)

This seems to have helped the screen reader identify where it is when focus is within the table.

When using Narrator in Edge or Accessibility tools with Firefox, the screen reader says the roles correctly, reads the column with the cell, can tell which column it is in, and which row it is in.
@pradeepnschrodinger pradeepnschrodinger mentioned this issue Jul 9, 2019
Merged
7 tasks
pradeepnschrodinger added a commit that referenced this issue Aug 6, 2019
@pradeepnschrodinger
Add roles and aria-attributes for initial screen reader support (Helps …
ce39a52 
…#440)
@pradeepnschrodinger pradeepnschrodinger mentioned this issue Aug 6, 2019
Merged
7 tasks
pradeepnschrodinger added a commit that referenced this issue Aug 8, 2019
@pradeepnschrodinger
Merge master to v1.0-beta (#475)
434d323 
Improvements/bug fixes that gets merged from master:

* Add roles and aria-attributes for initial screen reader support (#445) (Helps #440)
* Fix table scrolling while touch scroll is disabled (#458) (Fixes #456)
@pradeepnschrodinger pradeepnschrodinger mentioned this issue Sep 12, 2019
Merged
7 tasks
@pradeepnschrodinger
Copy link
Collaborator

Fixed with the v1.0.0 release through #445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wcjordan @pradeepnschrodinger @Tanner-MS