Beta update dependencies babel - Initial babel upgrade (step 1) #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests fail Site fails Probably build fails too
This was referenced May 23, 2019
| "transform-object-rest-spread", | ||
| "transform-object-assign", | ||
| "transform-class-properties", | ||
| ["@babel/plugin-transform-flow-strip-types", {"requireDirective": true}], |
There was a problem hiding this comment.
Babel seems to barf up on files like PrefixIntervalTree.js, due to flow annotations.
Using this plugin in to strip them off.
pradeepnschrodinger
requested review from
wcjordan,
tchoiSchrodinger,
quixotically,
novakps,
miskreant,
mycrobe and
somavara
somavara
approved these changes
May 28, 2019
wcjordan
approved these changes
May 28, 2019
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade babel to use v7
ran
npx babel-upgrade --write(see babel-upgrade)Navigate
#450 - Initial babel upgrade (*)
#451 - Calypso codemods
#452 - Fix site and tests
#453 - Fix internal build