-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for RFC 446 - ES6-style unicode escapes #19739
Comments
Note that stage 1 and the foundation for stage 2 in the migration strategy have been added by PR #19480 |
I know this is probably on your to-do list already, but I found an interesting corner-case in |
Though not mentioned in the RFC, we still have |
Hexidecimal doesn't suffer the same issues, because the full range is expressible, right? |
It seems weird to me that you can do this: I thought that |
cc @SimonSapin what do you think? |
I suggest leaving The reasoning behind the
|
Oh, looks like I completely misread you, sorry. Yes, removing |
I have opened a PR here to update the documentation in relation to this change. |
This has been completed. |
In Rust, it's recommended to use short (non-zero-padded) code-points inside ES6-style escaping sequences (`\u{...}`), as it reduces the length of the literal, and works better on the eyes for average use cases, while mechanical parsing remains still fairly easy. See examples in the Rust RFC and related discussion: * /~https://github.com/rust-lang/rfcs/blob/master/text/0446-es6-unicode-escapes.md * rust-lang/rfcs#446 * rust-lang/rust#19739
Remove
\u203D
and\U0001F4A9
unicode string escapes, and add ECMAScript 6-style\u{1F4A9}
escapes instead.Text: /~https://github.com/rust-lang/rfcs/blob/master/text/0446-es6-unicode-escapes.md
RFC PR: rust-lang/rfcs#446
Migration strategy: /~https://github.com/rust-lang/rfcs/blob/master/text/0446-es6-unicode-escapes.md#migration-strategy
The text was updated successfully, but these errors were encountered: