Restrict "\xXX" to ASCII (0x00 -- 0x7F) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted to make it clear, however, that the prior discussions were really in a different context, namely when we were trying to resolve the question "does \xXX denote a code *unit* or a code *point*." This RFC is proposing a way to side-step that question entirely, at least in the context of string literals. (I'll leave aside the question of if we are really side-stepping it, given our treatment of byte-string literals.)
These admittedly weaken my "source of confusion" argument. Nonetheless, I still think the case for `\xXX` for `XX > 0x7F` is weak.
|
+1, this is the conservative, consistent choice. And even if in the future people want to change or revert this change again, it would be backwards compatible because you can extend the semantic of ASCII-only |
pnkfelix
changed the title
withoutboats
pushed a commit
to withoutboats/rfcs
that referenced
this pull request
Jan 15, 2017
stream::repeat_item
Centril
added
A-syntax
wycats
pushed a commit
to wycats/rust-rfcs
that referenced
this pull request
Mar 5, 2019
* rfc text * add date * fix sp * fix word * add deprecation target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active: /~https://github.com/rust-lang/rfcs/blob/master/text/0326-restrict-xXX-to-ascii.md
Fix #312