Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: support ES6-style unicode escapes #19480

Merged
merged 1 commit into from
Dec 5, 2014
Merged

syntax: support ES6-style unicode escapes #19480

merged 1 commit into from
Dec 5, 2014

Conversation

emberian
Copy link
Member

@emberian emberian commented Dec 3, 2014

First half of bootstrapping rust-lang/rfcs#446

@alexcrichton
Copy link
Member

Before we push too hard on a new language feature like this, @cmr could you add a more extensive suite of regression tests? I'd be curious to see what happens for cases like:

  • a string with multiple escape sequences
  • a string like \\{20} where the initial backslash is escaped
  • a string with a non-matching brace
  • an escape sequence for a surrogate hex specifier
  • an escape for a too-large hex specifier
  • an escape which isn't hex

@emberian
Copy link
Member Author

emberian commented Dec 3, 2014

@alexcrichton all excellent testcases, I'll add these.

@alexcrichton
Copy link
Member

Thanks @cmr! Forgot to say, but r=me with those added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants