[conversion/rust] Remove zero-padding from ES6-style escaping #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rust, it's recommended to use short (non-zero-padded) code-points
inside ES6-style escaping sequences (`\u{...}`), as it reduces the
length of the literal, and works better on the eyes for average use
cases, while mechanical parsing remains still fairly easy.
See examples in the Rust RFC and related discussion:
* /~https://github.com/rust-lang/rfcs/blob/master/text/0446-es6-unicode-escapes.md
* rust-lang/rfcs#446
* rust-lang/rust#19739
|
@hsivonen support for rust-style escapes was a request from you. Are you happy to make this change? |
|
I guess I don't care particularly strongly either way, but I note that I don't see the referenced URLs supporting the assertion that omitting the leading zeros is recommended. (I see only one mention of the syntax making the omission of leading zeros possible.) |
|
Right, @hsivonen, there's no clear indication anywhere, but a common pattern I've noticed while dealing with the code. |
|
Let's close this. The patch is here if there's any interest. |
|
Done at https://r12a.github.io/app-conversion/. I will shortly redirect users to that location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust, it's recommended to use short (non-zero-padded) code-points
inside ES6-style escaping sequences (
\u{...}), as it reduces thelength of the literal, and works better on the eyes for average use
cases, while mechanical parsing remains still fairly easy.
See examples in the Rust RFC and related discussion:
In action:
