Skip to content

Commit

Permalink
merge: #590
Browse files Browse the repository at this point in the history
590: ci: use major version for actions/setup-java r=saig0 a=korthout

## Description

<!-- Please explain the changes you made here. -->

Changes the version used for actions/setup-java in all workflows to major version `v3`.

This should reduce the amount of effort needed to update this action (i.e. no more dependabot pull requests unless a new major version is released).

It should also avoid problems when actions/setup-java removes a specific patch release tag (as has happened before, see pull request mentioned below).

Using a major version is possible because GH recommends moving the major release tags along with the minor and patch releases of that same version.

Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Since we don't necessarily depend on a specific version, we should trust the maintainers of the action to adhere to semver.

## Related issues

<!-- Which issues are closed by this PR or are related -->

discussed in #589 (comment)

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](/~https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible) before requesting a review. -->

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to backport the fix

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually

Documentation:
* [ ] Javadoc has been written
* [ ] The documentation is updated


Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
  • Loading branch information
zeebe-bors-camunda[bot] and korthout authored Dec 6, 2022
2 parents 72edee9 + 838d693 commit 082acb5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand All @@ -100,7 +100,7 @@ jobs:
IMAGE_TAG_KEY: container.image.tag

- name: Downgrade Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-artifact.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
secret/data/github.com/organizations/camunda MAVEN_CENTRAL_GPG_SIGNING_KEY_SEC;
- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshot-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down

0 comments on commit 082acb5

Please sign in to comment.