Skip to content

Commit

Permalink
ci: use major version for actions/setup-java
Browse files Browse the repository at this point in the history
It might be better to switch the version to the latest major release v3.
Such tags are generally moved with every new minor and patch release of
the major version. This practice is officially recommended by GH.

Note that this may result in reduced reproducibility. However, since all
tags can be moved, the only way to guarantee reproducibility is by
pinning specific commit shas.

Likely it is easiest for us when using actions like these (e.g.
checkout) to use the major version tag.
  • Loading branch information
korthout committed Dec 6, 2022
1 parent 72edee9 commit 838d693
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand All @@ -100,7 +100,7 @@ jobs:
IMAGE_TAG_KEY: container.image.tag

- name: Downgrade Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-artifact.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
secret/data/github.com/organizations/camunda MAVEN_CENTRAL_GPG_SIGNING_KEY_SEC;
- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshot-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Java environment
uses: actions/setup-java@v3.6.0
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Expand Down

0 comments on commit 838d693

Please sign in to comment.