ci: use major version for actions/setup-java #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be better to switch the version to the latest major release v3. Such tags are generally moved with every new minor and patch release of the major version. This practice is officially recommended by GH. Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Likely it is easiest for us when using actions like these (e.g. checkout) to use the major version tag.
saig0
approved these changes
Dec 6, 2022
|
Build succeeded:
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the version used for actions/setup-java in all workflows to major version
v3.This should reduce the amount of effort needed to update this action (i.e. no more dependabot pull requests unless a new major version is released).
It should also avoid problems when actions/setup-java removes a specific patch release tag (as has happened before, see pull request mentioned below).
Using a major version is possible because GH recommends moving the major release tags along with the minor and patch releases of that same version.
Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Since we don't necessarily depend on a specific version, we should trust the maintainers of the action to adhere to semver.
Related issues
discussed in #589 (comment)
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: