Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement distribution spec and contractual build plan RFCs #149

Merged
merged 23 commits into from
Aug 7, 2019
Merged

Implement distribution spec and contractual build plan RFCs #149

merged 23 commits into from
Aug 7, 2019

Conversation

sclevine
Copy link
Member

@sclevine sclevine commented Jul 9, 2019 •
edited
Loading

Context:
buildpacks/rfcs#11
buildpacks/rfcs#12

Spec PR for build plan: buildpacks/spec#52
Spec PR for distribution spec: buildpacks/spec#53

@sclevine sclevine requested a review from ekcasey July 9, 2019 06:11
@sclevine sclevine force-pushed the dist-spec-and-build-plan branch from decb68d to 3b08815 Compare July 9, 2019 06:28
@sclevine
Copy link
Member Author

sclevine commented Jul 9, 2019

@jkutner @hone @nebhale this is ready to test out, but you'll need to manually construct the builder

This was referenced Jul 11, 2019
Merged
Merged
@jromero jromero added the breaking change Known to be non-backwards compatible label Jul 12, 2019
@sclevine sclevine mentioned this pull request Jul 14, 2019
Closed
ameyer-pivotal
ameyer-pivotal reviewed Jul 15, 2019
View reviewed changes
Makefile Outdated
GOENV=GO111MODULE=on GOOS=linux GOARCH=amd64 CGO_ENABLED=0
export GO111MODULE = on

GOCMD=go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the ? so that it's overridable from the command line (we often swap out to richgo)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yep, keep it.

@jromero jromero added this to the 0.4.0 milestone Jul 16, 2019
@jromero jromero mentioned this pull request Jul 18, 2019
Closed
@sclevine sclevine mentioned this pull request Jul 24, 2019
Merged
@sclevine sclevine force-pushed the dist-spec-and-build-plan branch 7 times, most recently from 22485b7 to 723079f Compare July 26, 2019 05:17
@sclevine
Copy link
Member Author

Updated to match buildpacks/rfcs#15.

@sclevine sclevine force-pushed the dist-spec-and-build-plan branch from 6e07d44 to 58b8064 Compare July 26, 2019 06:18
jromero pushed a commit to buildpacks/pack that referenced this pull request Aug 2, 2019
@ameyer-pivotal @jromero
Adds basic compatibility with buildpacks/lifecycle#149
2f6eafc 
Resolves #243

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
@jromero jromero mentioned this pull request Aug 2, 2019
Merged
ameyer-pivotal added a commit to buildpacks/pack that referenced this pull request Aug 5, 2019
@ameyer-pivotal
Adds basic compatibility with buildpacks/lifecycle#149
c93662a 
Resolves #243

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
ameyer-pivotal added a commit to buildpacks/pack that referenced this pull request Aug 5, 2019
@ameyer-pivotal
Adds basic compatibility with buildpacks/lifecycle#149
d348e26 
Resolves #243

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
ameyer-pivotal added a commit to buildpacks/pack that referenced this pull request Aug 5, 2019
@ameyer-pivotal
Adds basic compatibility with buildpacks/lifecycle#149
a42a358 
Resolves #243

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
sclevine added 21 commits August 7, 2019 11:59
@sclevine
wip wg
7cd824e 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
wip done cleanup
b019bd9 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
fix wg
b121285 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
wip - build plan cleanup
83e7400 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
wip - finish detection
cdd7cdf 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Finish POC for RFCs #11 and #12
9178535 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
misc cleanup / refactoring
32ebbe4
@sclevine
Small fixes for build plan / dist changes
47c15d0 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Add basic detect tests for build plan / dist spec
08a8dfe 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Finish dist spec / build plan detector + tests
8923fd9 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Finish dist spec and build plan changes
be39488 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Remove ? from Makefile + gofmt
77ae7ed 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Update for WG meeting 7/24
cc5ae99 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Fix bug with optional, multi-plan buildpacks
1bac60d 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Add trial count to detector
558f6b4 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Small fixes
452d924 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Tests pass with new dist spec / build plan changes
11563ce 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Finish dist spec + build plan updates
ff7092e 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Add yj to CI for tests
193ed3a
@sclevine
Fix flakey detection tests
0c0328b 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Fix merge conflicts
a13fe0a 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine sclevine force-pushed the dist-spec-and-build-plan branch from 58b8064 to a13fe0a Compare August 7, 2019 17:28
@sclevine
Fix Makefile whitespace
22c8aab 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine sclevine merged commit f16cbd7 into master Aug 7, 2019
ekcasey pushed a commit to buildpacks/pack that referenced this pull request Aug 12, 2019
@ameyer-pivotal @jromero
Adds basic compatibility with buildpacks/lifecycle#149
a27f11b 
Resolves #243

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
jromero added a commit to buildpacks/pack that referenced this pull request Aug 13, 2019
@jromero
Merge pull request #250 from buildpack/feature/243-basic-compat
9a06115 
Adds basic compatibility with buildpacks/lifecycle#149
@ekcasey ekcasey deleted the dist-spec-and-build-plan branch November 25, 2019 18:58
@ekcasey ekcasey mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameyer-pivotal ameyer-pivotal ameyer-pivotal left review comments

@ekcasey ekcasey ekcasey approved these changes

Assignees
No one assigned
Labels
breaking change Known to be non-backwards compatible
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sclevine @ekcasey @ameyer-pivotal @jromero