Contractual build plan #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
jkutner
reviewed
Jul 11, 2019
buildpack.md
Outdated
| For a given buildpack group, | ||
| - If a required buildpack provides a dependency that is not required by the same buildpack or a subsequent buildpack, the group MUST fail to detect. | ||
| - If a required buildpack requires a dependency that is not provided by the same buildpack or a previous buildpack, the group MUST fail to detect. | ||
| - If an optional buildpack provides a dependency that is not required by the same buildpack or a subsequent buildpack, it MUST be excluded from the build phase and its requires and provides MUST be excluded from the Build Plan. |
There was a problem hiding this comment.
can we clarify that "it" (as in "it MUST be excluded") is the optional buildpack, and not the thing that was provided?
jkutner
approved these changes
Jul 11, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
nebhale
approved these changes
Jul 25, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
|
@hone updated to match dist spec requirements. Awaiting approval 😄 |
hone
reviewed
Jul 26, 2019
| name = "<dependency name>" | ||
| version = "<dependency version>" | ||
|
|
||
| [requires.metadata] |
There was a problem hiding this comment.
according to the Contractual Build Plan RFC, requires doesn't have a metadata section.
There was a problem hiding this comment.
Good catch (assuming you mean provides). Fixed :)
hone
approved these changes
Jul 26, 2019
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC PR: buildpacks/rfcs#12
Lifecycle PR: buildpacks/lifecycle#149