Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOM to build metadata label #156

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

jromero
Copy link
Member

@jromero jromero commented Jul 24, 2019

Resolved #144

Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io

exporter.go Outdated Show resolved Hide resolved
exporter_test.go Outdated Show resolved Hide resolved
Copy link
Member

@sclevine sclevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jromero jromero force-pushed the feature/144-bom-metadata-label branch 2 times, most recently from 87d1fa9 to 59490f0 Compare July 24, 2019 21:52
@jromero jromero requested review from sclevine, ekcasey, jkutner and hone July 24, 2019 21:53
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good expect that one stray import. Let's discuss testify with @sclevine

exporter.go Show resolved Hide resolved
Resolved #144

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Signed-off-by: Javier Romero <jromero@pivotal.io>
@jromero jromero force-pushed the feature/144-bom-metadata-label branch from 59490f0 to 410f2ad Compare July 26, 2019 13:37
@ekcasey ekcasey merged commit 1f1b9c5 into master Jul 26, 2019
@jromero jromero deleted the feature/144-bom-metadata-label branch July 26, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BOM to build metadata label
3 participants