Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std support to bevy_transform #17030

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Add no_std support to bevy_transform #17030

merged 4 commits into from
Dec 30, 2024

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Added the following features:
    • std (default)
    • alloc (default)
    • bevy_reflect (default)
    • libm

Testing

  • CI

Notes

  • alloc feature added to allow using this crate in no_alloc environments.
  • bevy_reflect was previously always enabled when bevy-support was enabled, which isn't how most other crates handle reflection. I've brought this in line with how most crates gate bevy_reflect.

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible A-Transform Translations, rotations and scales X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 29, 2024
@bushrat011899 bushrat011899 mentioned this pull request Dec 29, 2024
Open
@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Dec 30, 2024
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 30, 2024
Merged via the queue into bevyengine:main with commit db5c31e Dec 30, 2024
34 checks passed
@TimJentzsch TimJentzsch added the O-Embedded Weird hardware and no_std platforms label Dec 31, 2024
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@bushrat011899 @ecoskey
Add no_std support to bevy_transform (bevyengine#17030)
eb89c37 
# Objective

- Contributes to bevyengine#15460

## Solution

- Added the following features:
  - `std` (default)
  - `alloc` (default)
  - `bevy_reflect` (default)
  - `libm`

## Testing

- CI

## Notes

- `alloc` feature added to allow using this crate in `no_alloc`
environments.
- `bevy_reflect` was previously always enabled when `bevy-support` was
enabled, which isn't how most other crates handle reflection. I've
brought this in line with how most crates gate `bevy_reflect`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bushrat011899 @alice-i-cecile @BenjaminBrienen @TimJentzsch