-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox e2e test #206
Sandbox e2e test #206
Changes from 20 commits
c92c58e
8e7a1e7
331ccea
fe1c2f7
7fea057
b54443e
ca0f257
db007f8
09be50e
b2c7ba1
8a6b31b
980703c
8bad67d
5b9eaf5
5e323fb
8566546
e511c74
a0c24a6
75ea586
6b9dae0
12f66d0
5dc0262
f2de8fa
0852f6c
0e5173b
3f0d9eb
1423594
0855fa1
ede58fd
d996c8e
c6c5fe6
3cc7d7d
a90e954
b7e5fd6
9718ab6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
"clean:npm-proxy": "npm run stop:npm-proxy && rimraf verdaccio-cache verdaccio-logs.txt", | ||
"diff:check": "tsx scripts/check_pr_size.ts", | ||
"docs": "typedoc", | ||
"e2e": "tsx --test --test-reporter spec --test-name-pattern \"/^\\[E2E\\]/\" packages/integration-tests/lib/e2e", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible to use path convention instead of test name convention ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately it doesn't look like the node test runner supports glob file patterns which is why I went with this approach. I can do a little more digging though because there is this issue which is closed but it still doesn't look like the feature is documented There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One other option is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've updated to using a combination of glob and grep in the test command to run only the paths we care about without relying on specific test name prefixes |
||
"install:local": "npm install && npm run build && npm run install:local --workspaces --if-present", | ||
"lint": "eslint --max-warnings 0 . && prettier --check .", | ||
"lint:fix": "eslint --cache --fix . && prettier --write .", | ||
|
@@ -21,7 +22,7 @@ | |
"publish:local": "tsx scripts/publish_local.ts", | ||
"start:npm-proxy": "tsx scripts/start_npm_proxy.ts", | ||
"stop:npm-proxy": "tsx scripts/stop_npm_proxy.ts", | ||
"test": "tsx --test --test-reporter spec", | ||
"test": "tsx --test --test-reporter spec --test-name-pattern \"/^[^\\[][^E][^2][^E][^\\]].*$/\"", | ||
"test:coverage:generate": "NODE_V8_COVERAGE=coverage/ npm run test", | ||
"test:coverage:threshold": "c8 npm run test", | ||
"update:api": "npm run update:api --workspaces", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because restoring from cache is a different file. So even though it's restoring a symlink, the link is now broken