Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox e2e test #206

Merged
merged 35 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c92c58e
fixup
edwardfoyle Sep 1, 2023
8e7a1e7
e2e working
edwardfoyle Sep 2, 2023
331ccea
remove unnecessary promise
edwardfoyle Sep 5, 2023
fe1c2f7
make process controller more ergonomic
edwardfoyle Sep 5, 2023
7fea057
fix pathing
edwardfoyle Sep 5, 2023
b54443e
refactor macros
edwardfoyle Sep 5, 2023
ca0f257
fix build
edwardfoyle Sep 5, 2023
db007f8
Merge remote-tracking branch 'origin/main' into e2e-tests
edwardfoyle Sep 5, 2023
09be50e
update e2e runner
edwardfoyle Sep 5, 2023
b2c7ba1
add debugging config
edwardfoyle Sep 5, 2023
8a6b31b
update debug config
edwardfoyle Sep 5, 2023
980703c
update setup
edwardfoyle Sep 5, 2023
8bad67d
add debug config
edwardfoyle Sep 5, 2023
5b9eaf5
try this
edwardfoyle Sep 5, 2023
5e323fb
add randomness to project names
edwardfoyle Sep 5, 2023
8566546
update workflow deps
edwardfoyle Sep 5, 2023
e511c74
fix indexing
edwardfoyle Sep 5, 2023
a0c24a6
fix types
edwardfoyle Sep 5, 2023
75ea586
revert package json change
edwardfoyle Sep 5, 2023
6b9dae0
remove debug config
edwardfoyle Sep 5, 2023
12f66d0
Merge remote-tracking branch 'origin/main' into e2e-tests
edwardfoyle Sep 6, 2023
5dc0262
update test glob patterns
edwardfoyle Sep 6, 2023
f2de8fa
remove e2e prefix
edwardfoyle Sep 6, 2023
0852f6c
update gitignore
edwardfoyle Sep 6, 2023
0e5173b
refactor creating test dir
edwardfoyle Sep 6, 2023
3f0d9eb
renaming things
edwardfoyle Sep 6, 2023
1423594
update comment
edwardfoyle Sep 6, 2023
0855fa1
fix path
edwardfoyle Sep 6, 2023
ede58fd
ignore integration-test package in coverage analysis
edwardfoyle Sep 6, 2023
d996c8e
update parcel watcher
edwardfoyle Sep 6, 2023
c6c5fe6
regenerate package lock
edwardfoyle Sep 6, 2023
3cc7d7d
fix queue shifting
edwardfoyle Sep 6, 2023
a90e954
revert some auto renaming
edwardfoyle Sep 6, 2023
b7e5fd6
rename ControllerAction => StdioInteraction and related names
edwardfoyle Sep 7, 2023
9718ab6
add empty changeset
edwardfoyle Sep 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert some auto renaming
  • Loading branch information
edwardfoyle committed Sep 6, 2023
commit a90e954b2f55d9a540edbc5ae581cc84bb57628a
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { AppNameAndBranchMainStackNameResolver } from './stack-name-resolvers/ap
/**
* This type reaches into the internals of the ClientConfigGenerator implementation
* to allow us to pull out the stackNameResolver that has been injected into the class.
* Not great, but until we have test-e2e tests it gives us more confidence that the factory wired everything together properly
* Not great, but until we have e2e tests it gives us more confidence that the factory wired everything together properly
*/
type GeneratorInternalType = {
outputRetrievalStrategy: {
Expand Down
4 changes: 2 additions & 2 deletions packages/create-amplify/src/create_amplify.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import { after, afterEach, before, beforeEach, describe, it } from 'node:test';
import assert from 'assert';

/**
* This test is more of an test-e2e test than a unit test.
* This test is more of an e2e test than a unit test.
* But there's really no way to test the create_amplify script without just running the real thing
*
* TODO: we may want to pull this test into our test-e2e suite once we have that setup
* TODO: we may want to pull this test into our e2e suite once we have that setup
* /~https://github.com/aws-amplify/samsara-cli/issues/136
*/
describe('create-amplify script', () => {
Expand Down