Sandbox e2e test #206
Sandbox e2e test #206
Conversation
🦋 Changeset detectedLatest commit: 9718ab6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edwardfoyle
added
the
run-e2e
package.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| "clean:npm-proxy": "npm run stop:npm-proxy && rimraf verdaccio-cache verdaccio-logs.txt", | |||
| "diff:check": "tsx scripts/check_pr_size.ts", | |||
| "docs": "typedoc", | |||
| "e2e": "tsx --test --test-reporter spec --test-name-pattern \"/^\\[E2E\\]/\" packages/integration-tests/lib/e2e", | |||
There was a problem hiding this comment.
is it possible to use path convention instead of test name convention ?
There was a problem hiding this comment.
Unfortunately it doesn't look like the node test runner supports glob file patterns which is why I went with this approach. I can do a little more digging though because there is this issue which is closed but it still doesn't look like the feature is documented
There was a problem hiding this comment.
One other option is
describe('foo', { skip: /** evaluate some logic to determine test category **/}, ()=> {...
but that would mean being verbose in unit tests...
There was a problem hiding this comment.
I've updated to using a combination of glob and grep in the test command to run only the paths we care about without relying on specific test name prefixes
| # we have to build and install in this job rather than restore from cache because the | ||
| # symlinks in the node_modules folder are broken if we just restore the build from the cache |
There was a problem hiding this comment.
Because restoring from cache is a different file. So even though it's restoring a symlink, the link is now broken
packages/integration-tests/src/process-controller/expected_line_action.ts
Outdated
Show resolved
Hide resolved
packages/integration-tests/src/process-controller/line_action_queue_builder.ts
Outdated
Show resolved
Hide resolved
packages/integration-tests/src/process-controller/controller_action_queue_builder.ts
Outdated
Show resolved
Hide resolved
Issue #, if available:
Fixes #46
Description of changes:
Adds a lightweight e2e framework for controlling the CLI. Adds a sandbox e2e test that checks that sandbox deploy of a basic project works and produces expected output.
There are several snapshot updates that were triggered by changing the file structure of the test projects to match the defined file convention of
<projectRoot>/amplify/backend.ts.The bulk of the functional changes are in the
integration-testspackage. I decided to put e2e tests in this package because they are a form of integration test and it allows us to easily reuse the same test project templates in both integration and e2e tests.Out of scope:
sandbox deletefrom cleaning up all resources. This should be fixed within the week. For now, we can manually clean up resources if/when we hit limitsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.