Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) #328

abraunegg · 2019-01-04T21:22:02Z

Issue #323 extreme debugging

* Add --force-http-1.1 flag to downgrade any HTTP/2 curl operations to HTTP 1.1 protocol * Explicitly set all bool items to false at initialisation * Update --display-config to display sync_list if configured * Add debug handling to display when sync_list is loaded * Add debug handling to output the handling of OneDrive changes

* update extra debugging

* Fix introduced core.exception.AssertError@src/itemdb.d(341): Assertion failure

* Add further debugging to print out changes reported by OneDrive

* add debugging as to how and where 'unwanted' is being set

…mote' shared items * Add more debugging output * Update to handle where OneDrive does not provide correct change objects for 'remote' shared items

* Fix missing declaration

* Update error messaging

* Update debug messaging

* Update debugging output

* Update debugging

* Update handling of the 'remote' but 'local' database entry as prior logic appears to have been changed by OneDrive

abraunegg · 2019-01-05T04:47:55Z

Prior to (potentially this is a OneDrive API change being rolled out), a 'change' record for the 'remote' folder consisted only of the following:

        "id": "BC7D88EC1F539DCF!107",
        "name": "3A",
        "parentReference": {
		"driveId": "bc7d88ec1f539dcf",
		"driveType": "personal"
	},

Note: Only 'driveId' & 'driveType' present.

In issues #323 & #324 however, all of these same reference items contained an 'id':

	"id": "7EF2789E900D35F3!105",
	"name": "DESIGN _ BRASIL",
	"parentReference": {
		"driveId": "7ef2789e900d35f3",
		"driveType": "personal",
		"id": "7EF2789E900D35F3!101"
	},

As such, because of the presence of 'id', the 'change' was being flagged as an actual item to sync. rather than being the database 'glue' to tie the local OneDrive entry to the remotely shared item.

The real fix for this is 37b3c76 however this PR incoporates all of the work in #327 as well, plus adding in a whole lot of extra debugging that helped get to the bottom of this

This reverts commit 388cc1d

norbusan · 2019-01-05T14:10:12Z

Hi @abraunegg
can we please go step by step ... this PR is based on top of extra-debugging-and-http-downgrade with some changes. I think the code is fine, but I would like to go one by one, if you don't mind...

abraunegg · 2019-01-05T18:41:11Z

@norbusan
Agree - this PR needs cleanup which I will be doing shortly

* Update from master

* Remove added db search for remote id as this is no longer required & effectivly would never get used / reached if remote 'item' is handled correctly & inserted properly

* remove printing of sql query & response as no longer required

* add what the item id is to verbose debug output

norbusan · 2019-01-05T23:55:40Z

Hi @abraunegg
so for now I wait with review and testing ...

abraunegg · 2019-01-05T23:58:48Z

@norbusan
Cleanup of code / changes all done - testing & review should be OK to proceed with this PR

norbusan

Build and run tested, the changes look reasonable, as well as the debug output when files are added/removed.

lock · 2019-01-13T16:21:46Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

abraunegg added 5 commits January 4, 2019 08:39

update extra debugging

e946269

* update extra debugging

Update sync.d

9e01d53

* Fix introduced core.exception.AssertError@src/itemdb.d(341): Assertion failure

Update sync.d

378a90c

* Add further debugging to print out changes reported by OneDrive

Update sync.d

733cdae

* add debugging as to how and where 'unwanted' is being set

abraunegg mentioned this pull request Jan 4, 2019

Shared Personal folder not Synced #323

Closed

abraunegg added 6 commits January 5, 2019 10:37

Handle where OneDrive does not provide correct change objects for 're…

4c10296

…mote' shared items * Add more debugging output * Update to handle where OneDrive does not provide correct change objects for 'remote' shared items

Update itemdb.d

df8ada2

* Fix missing declaration

Merge branch 'master' into Issue-#323-Extreme-Debugging

f89691c

Update error messaging

b00d812

* Update error messaging

Update sync.d

324b041

* Update debug messaging

Update sync.d

85ef9dc

* Update debugging output

abraunegg mentioned this pull request Jan 5, 2019

Syncing only top level directories #324

Closed

3 tasks

abraunegg added 2 commits January 5, 2019 14:32

Update debugging

858a488

* Update debugging

Update sync.d

37b3c76

* Update handling of the 'remote' but 'local' database entry as prior logic appears to have been changed by OneDrive

abraunegg changed the title ~~Issue #323 extreme debugging~~ Update handling of 'remote' folder designation as 'root' items (Issue #323, #324) Jan 5, 2019

abraunegg requested a review from norbusan January 5, 2019 04:48

abraunegg mentioned this pull request Jan 5, 2019

Add extra debugging & http protocol downgrade (Issue #314) #327

Merged

rollback commit 388cc1d

bf28e84

This reverts commit 388cc1d

abraunegg mentioned this pull request Jan 5, 2019

Resolve Key not found: 'id' when handling HTTP 412 - Precondition Failed (Issue #325) #329

Merged

Merge branch 'master' into Issue-#323-Extreme-Debugging

04be400

abraunegg added 4 commits January 6, 2019 05:54

Update sync.d

59e3c09

* Update from master

remove added db search for remote id

c83df6f

* Remove added db search for remote id as this is no longer required & effectivly would never get used / reached if remote 'item' is handled correctly & inserted properly

Update itemdb.d

d42ca54

* remove printing of sql query & response as no longer required

Update sync.d

5f96340

* add what the item id is to verbose debug output

abraunegg mentioned this pull request Jan 6, 2019

core.exception.AssertError@src/itemdb.d(341): Assertion failure #331

Closed

abraunegg changed the title ~~Update handling of 'remote' folder designation as 'root' items (Issue #323, #324)~~ Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) Jan 6, 2019

norbusan approved these changes Jan 6, 2019

View reviewed changes

abraunegg merged commit b751632 into master Jan 6, 2019

abraunegg deleted the Issue-#323-Extreme-Debugging branch January 6, 2019 16:02

abraunegg added this to the 2.2.5 milestone Jan 6, 2019

lock bot locked and limited conversation to collaborators Jan 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) #328

Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) #328

abraunegg commented Jan 4, 2019

abraunegg commented Jan 5, 2019 •

edited

Loading

norbusan commented Jan 5, 2019

abraunegg commented Jan 5, 2019

norbusan commented Jan 5, 2019

abraunegg commented Jan 5, 2019

norbusan left a comment

lock bot commented Jan 13, 2019

Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) #328

Update handling of 'remote' folder designation as 'root' items (Issue #323, #324, #331) #328

Conversation

abraunegg commented Jan 4, 2019

abraunegg commented Jan 5, 2019 • edited Loading

norbusan commented Jan 5, 2019

abraunegg commented Jan 5, 2019

norbusan commented Jan 5, 2019

abraunegg commented Jan 5, 2019

norbusan left a comment

Choose a reason for hiding this comment

lock bot commented Jan 13, 2019

abraunegg commented Jan 5, 2019 •

edited

Loading