Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Key not found: 'id' when handling HTTP 412 - Precondition Failed (Issue #325) #329

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Resolve Key not found: 'id' when handling HTTP 412 - Precondition Failed (Issue #325) #329

merged 1 commit into from
Jan 5, 2019

Conversation

abraunegg
Copy link
Owner

  • Update HTTP 412 error notifications to better identify where 412 error is occuring
  • Add a check for 'id' key on metadata update to prevent 'std.json.JSONException@std/json.d(494): Key not found: id' (Issue HTTP 412 - Precondition Failed #325)

@abraunegg
Update sync.d
faa252e 
* Update HTTP 412 error notifications to better identify where 412 error is occuring
* Add a check for 'id' key on metadata update to prevent 'std.json.JSONException@std/json.d(494): Key not found: id' (Issue #325)
@abraunegg
Copy link
Owner Author

Original patch introduced a regression where local deletes were not being processed 'at all'. Commit 388cc1d rolled back.

The 'local delete' issue was showing up in PR #327 & #328 throwing off analysis as to why files were not being removed correctly.

@abraunegg abraunegg requested a review from norbusan January 5, 2019 07:16
@abraunegg abraunegg mentioned this pull request Jan 5, 2019
Closed
@bugz8unny69
Copy link

Hey, where is you re-write? Are you still exploring ?

@abraunegg
Copy link
Owner Author

@LHorace
Best to refer you to this comment: #232 (comment)

norbusan
norbusan approved these changes Jan 5, 2019
View reviewed changes
Copy link
Collaborator

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That definitely looks fine!

@abraunegg abraunegg merged commit ddc5d60 into master Jan 5, 2019
@abraunegg abraunegg deleted the issue-325-take-2 branch January 5, 2019 23:59
@abraunegg abraunegg added this to the 2.2.5 milestone Jan 6, 2019
@lock
Copy link

lock bot commented Jan 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@norbusan norbusan norbusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@abraunegg @bugz8unny69 @norbusan